Saltwater fish spawn in places I don't think they're supposed to, and don't spawn in places I think they are

[annelidCerebellum]

Checking through the Discord it seems that "saltwater" is intended to refer to strictly oceans. However, fish from the saltwater spawn table (red grouper, jellyfish, tuna) spawn in bodies of water in many non-ocean biomes and seemingly not at all in oceans.

Screenshots show results of tests conducted in a 1.19.3 install with no mods except for Aquaculture 2. Tests involved creating a single biome world of the biome in question (F3 screen is visible in each to see which, except for the screenshot of a plains world where I forgot), making a hole with water between y=50 and 63 (the levels at which fish naturally spawn according the Minecraft wiki), then using command blocks to continuously kill any fish that spawn and collect their drops.

Please note this testing covers only spawns of fish mobs in the world, not fishing drops, but I have incidentally pulled saltwater fish in seemingly freshwater biomes so it is likely the same issue applies.

[GirafiStudios]

Looks like I made a few mistakes, when moving over to the new mob spawn system in 1.19. For Jellyfish for example I had aciddently made it so it would only appear in the biomes it was not supposed to.

Will get out a fix sometime today :)

[GirafiStudios]

Same problem with Red Grouper & Tuna. From what I can tell from the pictures, those are the only 3 fish that´s the problem as well - unless I´m missing something?

[annelidCerebellum]

I don't think you're missing anything, that was my takeaway as well.