TeamMetallurgy / Aquaculture

Aquaculture is an expansion of Minecraft's base fishing system. It allows you to catch a variety of new fish with a brand new series of rods and tools
68 stars 71 forks source link

Publish to `/releases`? #477

Closed RokeJulianLockhart closed 1 week ago

RokeJulianLockhart commented 1 week ago

Rationale

Asking on behalf of @JaredRichardWilliam:

I ask because the 1.20.1 version doesn't appear to be published on Modrinth (solely 1.20.4 is), and I'd like to not acquire releases from CurseForge if I can avoid it, because I intend to use this mod in a modpack.

Feasibility

I imagine you use GitHub CI, so it shouldn't be difficult.

GirafiStudios commented 1 week ago

I don´t use Github CI. I have a Jenkins, if that´s what you´re after?

GirafiStudios commented 1 week ago

https://jenkins.girafi.dk/

RokeJulianLockhart commented 1 week ago

https://github.com/TeamMetallurgy/Aquaculture/issues/477#issuecomment-2380600776

Thanks, @GirafiStudios. Jenkins is good - https://jenkins.girafi.dk/job/Team%20Metallurgy%20Mods/job/Aquaculture/job/Aquaculture%202%201.20.1%20Release/ was exactly what we're looking for.

Perhaps mention it in https://github.com/TeamMetallurgy/Aquaculture/blob/9862098aa7969b98064a1517990e0bddbead9998/README.md#aquaculture-2, since https://github.com/TeamMetallurgy/Aquaculture/releases is empty without any explanation.

ALternatively, I imagine it wouldn't be difficult to hook Jenkins into publishing releases to GH, but I understand if that's undesirable because it's another point of maintenance. Consequently, I'll close the issue as invalid.