TeamMidnightDust / MidnightControls

A Minecraft mod adding controller support and enhanced controls overall.
https://midnightdust.eu/midnightcontrols/
MIT License
174 stars 28 forks source link

Crashes when joining e.g. play.wynncraft.com with mod called Wynntils #210

Closed jh-devv closed 9 months ago

jh-devv commented 1 year ago

Describe the bug Crashes when joining e.g. play.wynncraft.com with mod called Wynntils

To Reproduce Steps to reproduce the behavior:

  1. Open minecraft with both mods installed
  2. Click the "join wynncraft button" or join join the wynncraft server manually
  3. Crashes

Expected behavior The game would not crash

Desktop (please complete the following information):

Additional context I will attach the log here: crash-log-1.txt

Sincerely: jh-devv

jh-devv commented 1 year ago

Seens like the code doesn't check for null Also wynntils has a custom gui

jh-devv commented 1 year ago

More context: mod works if wynntils custom loading screen is disabled Seems like the custom loading screen doesn't have the "exit buttons" so the game just crashes

jh-devv commented 1 year ago

if i understand this correcly, checking if the button is "null" on the loading screen would fix it