TeamMidnightDust / MidnightLib

Common Library for Team MidnightDust's mods. Provides a config api, common utils, and cosmetics.
https://midnightdust.eu/midnightlib
MIT License
32 stars 15 forks source link

Due to JitPack trying to build MidnightLib with Java 8, JitPack cannot be used as a source for 0.3.0 as a dependency #4

Closed cocona20xx closed 2 years ago

cocona20xx commented 2 years ago

Basically, JitPack tries to build 0.3.0 with Java 8 instead of Java 16, fails, and then _prevents end users from downloading the mod as a dependency, as it thinks that the mod cannot be build. See the error log from JitPack for more details.

I'm going to see if its possible to force Gradle to use the correct java version in a way that this repo isn't doing in a fork, as well.

cocona20xx commented 2 years ago

Tried to use jitpack.yml to make jitpack build with java 16 in a forked repo, however it seems like jitpack no longer works properly in that regard, as it did absolutely nothing -.-

Motschen commented 2 years ago

JitPack kinda sucks, but you can get the library from the Modrinth maven. Add this to your repositories: maven { url = "https://api.modrinth.com/maven" }

And this to your dependencies: modImplementation "maven.modrinth:midnightlib:${project.midnightlib_version}" include "maven.modrinth:midnightlib:${project.midnightlib_version}"

And define the version in gradle.properties like this: midnightlib_version=0.3.0

cocona20xx commented 2 years ago

thanks a ton, didnt know about that!