2.0 beta requires a separate VLC installation

TeamMidnightDust / PictureSign

Use signs to display pictures from the web completely client-side!

https://modrinth.com/mods/picturesign

MIT License

9 stars 7 forks source link

2.0 beta requires a separate VLC installation #21

Open LemmaEOF opened 12 months ago

LemmaEOF commented 12 months ago

Right now, the PictureSign 2.0 beta will crash if there's not a separate VLC installation for libvlc.dll: https://mclo.gs/ZafbGSt

It feels like libvlc could possibly be bundled with the mod, though that might end up being complicated with different OSes and architectures.

There are also some people encountering this on Linux even with VLC installed, though it might be via flatpak.

ayakasuki commented 11 months ago

yes I just show VLC errors

Cynosphere commented 11 months ago

I have VLC installed through Scoop and I'm also crashing, so yes bundle the library.

OpenComputers drops Lua libraries in .minecraft depending on your OS and arch so it shouldn't be too hard to replicate that.

Martmists-GH commented 1 month ago

Depending on VLC also seems a bit overkill; perhaps it'd be an idea to depend on libav (ffmpeg) instead?

Motschen commented 3 weeks ago

This should work way better now, as I'm no longer using VideoLib, but WATERMeDIA instead. VLC is still required, but it will now actually be detected in many cases and WATERMeDIA already bundles the dlls on Windows x64. I'd also prefer to have this working with ffmpeg instead, this is something I'll look into in the future.