TeamMidnightDust / SwordBlocking

A minecraft fabric clientside mod to restore sword blocking if you have a shield in your offhand.
MIT License
15 stars 7 forks source link

Update to 1.19.4 #10

Closed unilock closed 1 year ago

unilock commented 1 year ago
HhiPyrene commented 1 year ago

Got crash crash-2023-04-01_00.32.57-client.txt

unilock commented 1 year ago

@HhiPyrene I can't reproduce with the set of mods in your crash log :(

Although, I may not have the exact same set of mods, since some of them weren't available via CurseForge nor Modrinth... (i.e. GitHub Actions)

Would you be able to archive your config + mods folders in a ZIP or what have you, and share a link to it here? (hopefully the legality of that isn't questionable enough to get me in trouble)

HhiPyrene commented 1 year ago

latest.log crash-2023-04-08_12.35.00-client.txt Though the other mods disabled, it still crashed. Maybe it's broken by QUILT, which seems a trouble.

unilock commented 1 year ago

@HhiPyrene I still can't reproduce, even with your exact setup :(

Minecraft: 1.19.4 Quilt: 0.19.0-beta.2 QFAPI / QSL: QFAPI 6.0.0-beta.2 + QSL 5.0.0-beta.1 SwordBlocking: 1.3.0 (my fork)

I'll try changing the InGameHud mixin from a @Redirect to an @Inject; maybe that'll fix it? (I am not sure how to do this elegantly :v )

HhiPyrene commented 1 year ago

I know why. Gradle 8.0 made the build broken, confusing us. I tried to use Gradle 7.5.1 to build again and it worked fine. :/ My mistake. build.zip

Motschen commented 1 year ago

Thank you very much :)