TeamMoegMC / Caupona

Food cuisine mod for minecraft
https://www.curseforge.com/minecraft/mc-mods/caupona
GNU General Public License v3.0
12 stars 8 forks source link

[Bug] Caupona's Saplings and Leaves can not be composted #81

Open f-raZ0R opened 6 months ago

f-raZ0R commented 6 months ago

Error Behaviour

You can not put walnut, fig, or wolfberry leaves or saplings into a composter. Other items, like their respective produce, or scraps, do go in. I have gone into further detail in this, as I have tried to fix this myself, but after several hours, I have given up. Here are my findings:

-When using EMI, which among other things, shows you compost rates of items, the compost rates of these saplings and leaves is at -100%, as opposed to non-compostable items, which don't show anything at all. This leads me to believe that they are correctly set to be compostable, but their rate isn't defined. -I have searched the entire repo for the string "sapling", and with some extensive pouring over things, I have not found anywhere where the compost rate of these saplings or leaves are actually defined.

Unfortunately, I do not know enough about how you do datagen to go ahead and define those myself.

Expected Behaviour

Saplings and leaves can be composted in a composter, and have a 30% chance to fill it up by one level, like vanilla.

Reproduce

Place a composter, and attempt to compost any of caupona's leaves or saplings. See how you are unable to do so. Do the same with a vanilla sapling, or any of caupona's other compostable items, and note that you are able to compost these.

Crash Report

Not Applicable

Mod version

0.4.9

Server version

Not Applicable

Other mods and plugins

EMI, 1.1.2 JEI, 15.3.0.4

f-raZ0R commented 6 months ago

Looking into this more, this seems to be #44 again, but the file CPDispenserBehaviour which contained the fix no longer exists?

f-raZ0R commented 6 months ago

okay yeah, that file got renamed at some point

it seems like at some point during refactors about a year ago, this got unfixed?

f-raZ0R commented 4 months ago

bumping this issue because my github was erroneously flagged, thus making this not visible for anyone besides me