TeamMoegMC / Caupona

Food cuisine mod for minecraft
https://www.curseforge.com/minecraft/mc-mods/caupona
GNU General Public License v3.0
12 stars 8 forks source link

[Bug] Pumice that cannot be breaked is produced. #89

Open TwelveYO21 opened 4 months ago

TwelveYO21 commented 4 months ago

Error Behaviour

As the title suggests. Unable to destroy pumice blooms naturally generated by volcanic vent.

Expected Behaviour

-

Reproduce

https://github.com/TeamMoegMC/Caupona/assets/58351699/590ebf68-9e75-4f71-951e-9d1ea9a642f2

Crash Report

No response

Mod version

caupona-1.20.1-0.4.9

Server version

neoforge-47.1.101

Other mods and plugins

No response

f-raZ0R commented 4 months ago

I actually encountered this too on a server, what other mods are you using?

It seems like there is a client-server desync going on, where the client thinks there is pumice there when there actually isn't.

https://github.com/TeamMoegMC/Caupona/assets/30442287/bdf12009-1751-4346-93d1-81ca3afac333

unilock commented 1 month ago

FumaroleVentBlockEntity#placeFumarole likely just needs a !pLevel.isClientSide check.

https://github.com/TeamMoegMC/Caupona/blob/acd9368d5c37e0dee7ec5dd4a6a9babd7db22153/src/main/java/com/teammoeg/caupona/blocks/fumarole/FumaroleVentBlockEntity.java#L103-L123