TeamMoegMC / SteamPowered

Advancing Create mod to Steam Age ⚙️
https://www.curseforge.com/minecraft/mc-mods/steam-powered-create
Other
19 stars 21 forks source link

[Bug] Create update broke Flywheel dependency #51

Open FemBane opened 2 months ago

FemBane commented 2 months ago

Error Behaviour

image Create Updated to Flywheel 6.11-13

Expected Behaviour

Update the upper bound for Flywheel versions

Reproduce

Install Create 1.20.1 v0.5.1h and steampowered-1.20.1-3.0.1.jar This will happen

Crash Report

No response

Mod version

3.0.1

Server version

No response

Other mods and plugins

No response

Oxy49 commented 2 months ago

Follow up ⬆️

FemBane commented 2 months ago

I just want my boilers ;(

SoOPlayer4400 commented 2 months ago

Im also having the same issue

therealKoolant commented 2 months ago

bump

Xalcon commented 1 month ago

Mods should not depend on the dependencies of other mods when they already depend on the mod. Depending on create 0.5.1+ already implies a dependency on flywheel. The project does not seem to reference the flywheel library at all (no reference to dev.engine_room.flywheel), which means an explicit dependency is just harmful. If create decides to remove flywheel in a minor update, this mod would break again. Having it in the build.gradle is more than sufficient.

For people that look for a temporary fix: You can open the steampowered jar file and edit the mods.toml inside the META-INF directory. In there you can either remove the whole dependency block for flywheel or change the version requirement for flywheel from the old

    versionRange="[0.6.10,0.6.11)"

to something like this:

    versionRange="[0.6.10,)"

The jar file is not signed, so editing its content is fine for personal use.

IslamSir commented 1 month ago

Same