TeamMoonstorm / Starstorm2

A sequel to the Risk of Rain 1 mod Starstorm, for RoR2. Featuring new survivors, enemies, items, bosses, gameplay mechanics, and more!
https://thunderstore.io/package/TeamMoonstorm/Starstorm2/
GNU General Public License v3.0
29 stars 33 forks source link

Molten coin spamming console every proc, KeyNotFoundException #216

Closed gregest closed 1 year ago

gregest commented 1 year ago

This is two separate errors but both are related to Starstorm so I thought I would put it in 1 report instead of making two separate

For molten coin, every time it procs it prints "Giving 0 Money" in the console, which becomes very frequent the further you go. Not sure what else I can say about this, it doesn't happen without molten coin.

The second one, I could not figure out when it happens but it would spam KeyNotFoundException with a very long stacktrace that first mentions Starstorm2, and then a few other mods

LogOutput.log

gaforb commented 1 year ago

The "Giving 0 Money" spam was caused by LIT's Life Savings until the most recent update I think - it would trigger on any Body being spawned. Try updating to the latest version of LIT and see if you still get spam.

As for the KeyNotFound error, that looks to be OnInventoryChanged - I suspect it's a conflict between TILER2's FakeInventory system that it uses for mimics and something else hooking the same function. It mentions several mods that all check the OnInventoryChanged function, including StarStorm2. Try disabling TILER2 and anything depending on it and see if the error still occurs.

gregest commented 1 year ago

I was sure that it was molten coin because I was watching the console until I procced it and it showed up as I procced it, I will try to disable tiler2, I did hear that it somehow breaks with everything

Darkmega18 commented 1 year ago

I saw some molten coin sound related spam myself, so I'm wondering if this is related?

stuff like this: [Warning:Moonstorm Shared Utils] Could not find sound event with name of MoltenCoin

prodzpod commented 1 year ago

love how this is 3 different issue that we cant really do anything with

Darkmega18 commented 1 year ago

oofs. ._.' I just figured it was all molten coin console spam related. meaning it was just right good busted.

wait. so does that mean I've been grabbing molten coin a bunch thinking it gives a bit of money but it actually hasn't really been doing anything for me? :V

prodzpod commented 1 year ago

The "Giving 0 Money" spam was caused by LIT's Life Savings until the most recent update I think - it would trigger on any Body being spawned. Try updating to the latest version of LIT and see if you still get spam.

As for the KeyNotFound error, that looks to be OnInventoryChanged - I suspect it's a conflict between TILER2's FakeInventory system that it uses for mimics and something else hooking the same function. It mentions several mods that all check the OnInventoryChanged function, including StarStorm2. Try disabling TILER2 and anything depending on it and see if the error still occurs.

have you tried these and does the issue persist

Darkmega18 commented 1 year ago

If I disable Tiler won't the mods requiring it start breaking? or do only specific portions of those mods require Tiler like the afformentioned mimic I actually have turned off?

I have the latest of LIT thats available on the launcher fairly certain. I always updated whenever I do. but I've since turned off their life savings for the classic items one for the gold over time rather than consumable gold burst at start of level.

I'll have to see exactly what my molten coin related spam is first to be sure on which fix I might need to try if it's even either.

prodzpod commented 1 year ago

TILER2 just updated actually, try the new version and see if the issue persists

Darkmega18 commented 1 year ago

well, I don't have any molten coin spam now it seems. played for a bit with classic bandit and picked it up fairly early. so theres that atleast.

prodzpod commented 1 year ago

epic thinkinvis win

Darkmega18 commented 1 year ago

I guess so. didn't see anything related to molten coin when I typed molten into the filter last couple of games. so, must be good now.