search

TeamMoonstorm / Starstorm2

A Port/Continuation of the Risk of Rain 1 mod: Starstorm.
GNU General Public License v3.0
29 stars 33 forks source link

TeamManager.GiveExperience randomly erroring out #288

Closed Phreelosu closed 1 year ago

Phreelosu commented 1 year ago

LogOutput.log

Completely randomly at either lvl 14, 19, 20 or 30 even the GiveExperience method errors out in an IndexOutOfRange exception form. It does NOT stop experience gain but it does lag the game like crazy.

Starstorm2 is literally the only mod that touches TeamManager, turning off this mod solves this issue and it isn't happening anymore

Phreelosu commented 1 year ago

Adding onto this, I talked about this to HIFU and he said if you just hook it and check if (self.teamExperience) before actually handling the given out XP it probably will not NRE, but I honestly have no idea how and when exactly this occurs, log is there, can provide multiple logs but it really happens randomly :(

Hevia commented 1 year ago

Acknowledging issue just so you know its being discussed and not ignored

Phreelosu commented 1 year ago

can confirm this does not happen on newest version anymore, most likely due to Baby's Toys being disabled

thanks for the fix xD