TeamMoonstorm / Starstorm2

A Port/Continuation of the Risk of Rain 1 mod: Starstorm.
GNU General Public License v3.0
26 stars 31 forks source link

Empyrean Elite becomes unkillable with additional Elite-mods (mod-compatability) #421

Open vialra opened 5 months ago

vialra commented 5 months ago

"Problem"

When combined with a big addition of extra elite types (through additional mods, so no starstorm-problem and maybe lower prio), the empyrean elite becomes unkillable due to it grabbing all elite-affixes. Fixing this issue would increase the compatability of Starstorm with other mods/larger modlists.

indeed very powerful energies begin to harmonize 😄 image

Solution

Possible solutions we found when thinking about it:

Code

From my analysis the process of loading the affixes has to be adjusted in this file empyrean-file

either here:

foreach (EliteDef ed in EliteCatalog.eliteDefs)
{
    //shitty hardcoded case for blighted; add actual cross compat later!
    if (ed.IsAvailable() && !blacklistedEliteDefs.Contains(ed) && !body.HasBuff(ed.eliteEquipmentDef.passiveBuffDef) && ed.modifierToken != "LIT_MODIFIER_BLIGHTED")
        body.AddBuff(ed.eliteEquipmentDef.passiveBuffDef);
}

or here:

private static void CreateBlacklist()
{
    AddEliteToBlacklist(RoR2Content.Elites.Lunar);
    AddEliteToBlacklist(DLC1Content.Elites.Void);
}
Hevia commented 5 months ago

Yeah we're aware. Swuff plans to release a config blacklist so you can control which elites are part of Empyrean. Swuff is really busy rn so no eta on the fix but it is top of mind on things to resolve, but it should be soon

Thanks for reporting!

vialra commented 5 months ago

Very cool ^^ Thanks for the Update/Reply :)