TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.63k stars 3.07k forks source link

SoundCloud Download "Unknown Quality" audio cannot be played #10153

Closed esn89 closed 1 year ago

esn89 commented 1 year ago

Checklist

Affected version

0.25.1

Steps to reproduce the bug

  1. Go to NewPipe
  2. Go to the SoundCloud option
  3. Find a song that allows you to download in bitrate higher than 125kbps. Normally it says "Unknown Quality" with a filesize significantly bigger than the default mp3 128kbps.
  4. Download it
  5. Try to play it with AIMP
  6. Go to terminal of your phone and do file $DOWNLOADED_FILE it says file type is just "data".

Expected behavior

I should be able to play this file.

Actual behavior

Music players cannot play the downloaded file. Linux does not detect the extension.

Screenshots/Screen recordings

screenshot

Logs

No crash logs.

Affected Android/Custom ROM version

Android 13, OxygenOS

Affected device model

OnePlus 8 Pro

Additional information

No response

opusforlife2 commented 1 year ago

Why have you put a link to this issue in the Screenshots section?

esn89 commented 1 year ago

Ooops, here is the image:

https://imgur.com/a/FzmS61B

opusforlife2 commented 1 year ago

You brave beast. I would have never touched a 1/2 GB file pretending to be an audio.

esn89 commented 1 year ago

@opusforlife2 since this is a whole DJ set about ~1 hour, it is quite possible if it is a flac :)

opusforlife2 commented 1 year ago

We don't parse any stream other than MP3 and Opus on Soundcloud, from what I remember.

TobiGr commented 1 year ago

@esn89 Please test the APK in #10165 . I was able to test the it with the song you provided in the screen shot. That download is an AIFF file. SoundCloud artists can upload streams with other formats, too. I was not able to find one which uses another format. If you do, please tell us if it works.

esn89 commented 1 year ago

@TobiGr , let me test this out. Give me some time :)

esn89 commented 1 year ago

It downloads, but, it saves as a 49.4mb mp3 instead.

TobiGr commented 1 year ago

@esn89 That's a regression which was recently introduced. I'll have to fix it first (see #10180)

TobiGr commented 1 year ago

Please test the latest APK once the build is finished, everything should work now.