TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.56k stars 3.07k forks source link

[PeerTube] Local kiosk unavailable on instances running PeerTube 6.0 and higher #10685

Open dragfyre opened 10 months ago

dragfyre commented 10 months ago

Checklist

Affected version

0.26.0

Steps to reproduce the bug

Access the local kiosk page of any PeerTube instance that has installed PeerTube v6.0.0 or later (e.g. diode.zone, spectra.video...)

Expected behavior

The local kiosk page of a PeerTube instance that runs v6+ should display all videos that are local to that instance.

Actual behavior

Local kiosk pages of PeerTube instances that run v6+ display a "Content unavailable" error. See Additional Information regarding a breaking change in PeerTube's REST API which is the source of this bug.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

No response

Affected device model

No response

Additional information

Since v6.0.0, PeerTube has removed the deprecated "filter" query from its REST API. The changelog notes:

Removed filter query when listing videos (deprecated since 4.0 in favour of isLocal and include)

A minor annoyance (as this issue only affects PeerTube instances which have updated to v6 and combined timelines still work properly), but I figured it's worth mentioning. It seems like all NewPipe versions are affected.

dragfyre commented 10 months ago

Relevant code found and PR submitted here.