Add user-facing settings for configuring the parameters of the skip-silence feature

User087 commented 6 months ago

Checklist

[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have read the FAQ and my problem isn't listed.
[X] I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
[X] I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
[X] This issue contains only one feature request.
[X] I have read and understood the contribution guidelines.

Feature description

Am I correct in thinking that this: https://github.com/google/ExoPlayer/issues/6705 having been resolved should make it possible to enable the user to configure the skip-silence feature, so they can change the minimum duration of silence to be skipped, the threshold volume below which is classified as 'silence', and the duration of 'padding' on the edges of any silent portion?

Similar to but more general than #10479

Why do you want this feature?

Having these parameters as configurable options could help in adapting the silence skipping to fit different videos which could differ in the volume of spoken parts and speed of speech etc. Being stuck with one set of values for those parameters can lead to the silence skipping being too agressive for some videos and not enough so for others.

Additional information

No response

ABJ4403 commented 6 months ago

Early mockup screenshot can give better idea of what we're expecting :/

I kinda wanted this too as well tho

jstetten commented 5 months ago

I personally feel like this is an important issue, if indeed implementable, not a niche one.

The biggest issue is the lack of any padding whatsoever on either side of the skipped portion, resulting in very, very speeded-up, unnatural and choppy speech. The end result, when enabled, is audio with (comparably) long pauses between clauses within sentences, coupled with zero pause whatsoever between sentences — the exact opposite of how human speech is meant to be comprehended.

For this reason, I rarely use the feature and settle for increasing playback speed and manually fast-forwarding when needed, instead. The drawbacks:

By the time I realize it, then pull my phone out of my pocket, unlock it, bring up NewPipe (or it's notification), and my thumb finds the ⏩ button, that moment likely already passed.
The amount of speed increase possible is limited by the speech rate of the fastest speaker in the conversation, beyond which they become unintelligible.

Removing silence from conversations is the first job of all pro audio editors, something applied to all (non-live) commercial audio we've consumed in every medium for the greater part of a century.

As is, I find it much too aggressive to use for the majority of videos I listen to, though I'd very much like to. Doesn't stop NewPipe from being an amazing app though!

User087 commented 5 months ago

TeamNewPipe / NewPipe