TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
30.88k stars 3.01k forks source link

Avoid copying comments by mistake #11033

Open r-ricci opened 3 months ago

r-ricci commented 3 months ago

Checklist

Feature description

Add a setting to disable the copy to clipboard behavior on long press over comments. Or, alternatively, just increase the long press duration.

Why do you want this feature?

Often, while scrolling comments, I accidentally copy them to the clipboard. I find this annoying because I don't like the idea of filling it with a random comment. Also, the clipboard may contain something which I don't want to be overwritten.

Additional information

No response

opusforlife2 commented 3 months ago

Long-press duration is decided by your OS, so if you encounter this problem here I wonder what happens when you're browsing a webpage with links.

I suppose we could open a menu offering the Copy to clipboard option instead of doing so directly.

r-ricci commented 3 months ago

Long-press duration is decided by your OS

I didn't know. I changed this setting and my comment-scrolling experience has improved. However, I prefer to keep a short long-press duration when using other apps.

I wonder what happens when you're browsing a webpage with links

I paid attention to my scrolling habits and I found out that I tend to keep the finger on the screen after a scroll movement, because I need time to look at the content and decide whether I want to keep scrolling or to stop. The reason I never had problems on web pages is that links on a web page are usually sparse, so there's a low chance of hitting a link by accident. Instead, in NewPipe, the whole area of a comment triggers the action on long-press and there's no gap between these areas.

Maybe the comment could be copied only when the user long-presses the comment header (the line with username and date). Otherwise, I'll try to change my scrolling habits.

opusforlife2 commented 3 months ago

Another alternative would be to place a clipboard icon opposite the commenter username. But that might cause a lot of clutter.

minecraftchest1 commented 2 months ago

I would personally prefer a menu with the option to copy the message, report the user, and block the user locally.

r-ricci commented 2 months ago

@minecraftchest1 I like the idea of a general purpose menu. After all, what makes copy-to-clipboard so special that it requires a dedicated gesture? Sometimes you want to do it, but how often? I also think report/block could be useful to some. However this functionality is not yet available in NewPipe, so it's beyond the scope of this discussion. You should open another issue.

I propose a button with a three-dots icon on the opposite side of the commenter's photo. It would pop up a menu containing only one entry (to copy the comment's text). Maybe other entries in the future.

@opusforlife2 I don't think such a button would bring much clutter. The Youtube website has a similar thing (to report the user) and it doesn't look very ugly.

opusforlife2 commented 2 months ago

Copy to clipboard for comments very likely isn't a frequently used mechanism, outside of any niche cases. It makes sense for it to have a button in a menu instead of a dedicated gesture, which could be used for something else, such as expand all/collapse all replies.