Tapping on timestamp causes popup player to start from beginning

wb9688 commented 3 months ago

Checklist

[X] I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have read the FAQ and my problem isn't listed.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug.
[X] I have read and understood the contribution guidelines.

Affected version

0.27.1

Steps to reproduce the bug

Open a video
Go to comments
View replies of a comment
Tap a timestamp in a reply

Expected behavior

The video starts in the popup player from that timestamp.

Actual behavior

The video starts in the popup player from the beginning.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 13

Affected device model

moto g52

Additional information

No response

wb9688 commented 3 months ago

This is not specific to clicking on it in a reply, so I updated the title.

Thompson3142 commented 4 days ago

Does that also happen once you have started the video? I can only reproduce this if either:

I have autoplay disabled and click on a timestamp before starting the video
I have played the video - opened a timestamp - closed it without resuming the video - open a timestamp again (can be the same)

If that is the case i probably know the issue: The playQueue in Player is null if a timestamp "starts" the player since initPlayback was never called. If handleIntent is called on a "fresh" (initPlayback was never called) Player object it can't handle timestamps since in the big if (in line 393) the playQueue is needed to create a pop-up with timestamp.

TeamNewPipe / NewPipe