Audioquality low on any videoquality

elec2 commented 2 months ago

Checklist

[X] I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have read the FAQ and my problem isn't listed.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug.
[X] I have read and understood the contribution guidelines.

Affected version

0.27.2

Steps to reproduce the bug

Open any video
Press play
Listen to the sound, especially low loudness noise sounds like beach or wind sounds.

Expected behavior

The sound quality should change together with the change of the videoquality.

Actual behavior

On every quality level, the soundquality is like with 360p video. I think it is 32bit/s Audio.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 14

Affected device model

Samsung Fold 4

Additional information

No response

n-ce commented 2 months ago

Duplicate of https://github.com/TeamNewPipe/NewPipe/issues/8148

elec2 commented 2 months ago

Duplicate of #8148

Sorry @n-ce , but it's definitely not the same problem, because some month ago the problem wasn't there. As the Autor of #8148 says: This only happens when using data AND in background mode. If I play a video with mobile data the audio is fine. When using WiFi the audio is fine in both cases.

This is not the case here! It happens in WLAN on mobile and no matter if the app is in background or not.

opusforlife2 commented 1 month ago

@elec2 Is your wifi network metered?

elec2 commented 1 month ago

@opusforlife2 no, but while I was testing this again now, I figured a different behavior. Now the sound in WLAN is always good (no matter the video quality settings) and the sound on mobile data is always bad (no matter the settings). This shouldn't be intended right? Because why do I have to rely on a bad audio quality while watching a video at 4k and while being on LTE (especially if I have unlimited data). Is the audio codec automatically selected from youtube or from newpipe?

opusforlife2 commented 1 month ago

What about background vs foreground then? No change in audio quality on mobile data?

elec2 commented 1 month ago

What about background vs foreground then? No change in audio quality on mobile data?

Exactly

AudricV commented 1 month ago

Setting the video resolution limit on mobile data to no limit should resolve the issue, using the lowest audio quality is based on that setting (see the call to isLimitingDataUsage in the code here)

This handling of audio quality based on video resolution limit and whether the network is metered should be completely removed and based on dedicated audio settings.

elec2 commented 1 month ago

Setting the video resolution limit on mobile data to no limit should resolve the issue,

Huh, you are right. Thank you!

TeamNewPipe / NewPipe