TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.7k stars 3.08k forks source link

Migrate build to version catalogs #11684

Open JL0000 opened 2 weeks ago

JL0000 commented 2 weeks ago

What is it?

Description of the changes in your PR

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Stypox commented 1 week ago

Thanks for the PR! This should go to the refactor branch though, as the dev branch is kind of in maintenance mode. You can change the base branch by clicking "Edit" next to the PR title.

Profpatsch commented 3 days ago

Okay, so I checked this out, squashed the last 3 commits into one, and I have to say I’m not particularly in favor of this.

Before, we had a pretty simple file with dependencies and their version numbers, now we have yet another toml file, and that file has yet another indirection, so we are introducing two indirections here for very little gain.

I’m in favor of closing this PR and the referenced issue as WONTDO

Profpatsch commented 3 days ago

I’d be okay with merging the change @JL0000 if you can clean up the history, squash everything into one commit and make it compatible with the current refactor branch.

snaik20 commented 3 days ago

@JL0000 It seems like the PR contains a lot of unrelated commits, likely due to updating the base branch on GitHub. To resolve this, you can rebase your branch locally onto the latest refactor branch and then push the changes again.

sonarcloud[bot] commented 1 hour ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud