TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.7k stars 3.08k forks source link

Only start playing single item in history screen #11696

Closed codyit closed 1 week ago

codyit commented 1 week ago

What is it?

Description of the changes in your PR

Before/After Screenshots/Screen Record

N/A

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Stypox commented 1 week ago

There are people that rely on this behavior (me included) and last time we changed something we got a lot of angry users. During the refactor we will look into redesigning the long-press menu to allow for all of these different options to co-exist (starting without enqueueing everything and starting a playlist from a specific item), but we can't just change one thing without thinking about the whole picture. Sorry about it, and thank you for your contribution anyway.

Stypox commented 1 week ago

Oh wait, you are just doing the change for the history fragment. Then I think the change makes sense.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud