Migrate empty_state_view xml/view to Jetpack Compose

[Profpatsch]

Followup rebase for https://github.com/TeamNewPipe/NewPipe/pull/11463 due to technical reasons.

Please see its description.

[Profpatsch]

A manual test clicking through the build on an empty newpipe seems that everything still works as expected.

[Profpatsch]

Some kaomoji that had different variants before seem to be the same now, maybe we want to keep that. Nevermind, that’s handled as well

[Profpatsch]

I’d merge soon, unless there are any vetoes

[Stypox]

Wait

[Stypox]

I think that the component's parameters are needlessly complicated. The only three items in the spec should be:

• modifier: () -> Modifier
• emojiText: () -> String
• descriptionText: () -> String

[Stypox]

[sonarcloud[bot]]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Stypox]

I pushed a few more commits, and now the code is better in my opinion. These things still need to be improved though (I don't know if it's better to do them now or in a future PR):

• storing a Modifier in the EmptyStateSpec is bad practice and also doesn't make much sense (it's the purpose of parent views to decide the modifiers of the children, it's not a property of the children themselves)
• the spacing of the UI is not perfect everywhere, but at least with the latest commit the panel is always centered
  • I can't understand why the "Select a playlist" dialog is tight, while "Select a channel" is larger, but I can't debug right now, see below why...
• (in a future PR!) the error panel should be merged with the empty state panel, since:
  • only one of them is shown at a time
  • the checks for errors are often close to the checks for emptiness, so some checks could be simplified
  • I'm not totally convinced of this though
• the empty state for unsupported content in the channel fragment does not work, but it didn't work before either, and both my Layout Inspector and by View Designer don't work, so I can't debug right now (Android Studio decided to go on vacation or something)

I tested all the screens above, in dark and light themes, and they work.

[Profpatsch]

Looks exceptionally good to me! (disclaimer: I didn’t test, since you already made screenshots)