TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.7k stars 3.08k forks source link

Always allow changing player notification preferences on Android 13+ #11738

Open cillyvms opened 9 hours ago

cillyvms commented 9 hours ago

What is it?

Description of the changes in your PR

Since Android 13 media player notifications are exempt from the notification settings/permission, however NewPipe currently disables all preferences in the notification section preventing the user from entering the player notification page. I have tested this on my device and neither the global notification toggle/permission, nor disabling the specific channel used for player notifications would hide it. Since system settings don't affect the display of the player notification, this PR makes it so that only the new stream notification preferences are disabled, when notifications are blocked by the system.

Before/After Screenshots/Screen Record

(Both screenshots taken on Android 15 with notification permission denied) Before After
Screenshot_before Screenshot_after

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

sonarcloud[bot] commented 1 hour ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud