TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.4k stars 3.06k forks source link

Sort local playlists in groups / folders #1313

Open justanidea opened 6 years ago

justanidea commented 6 years ago

It could be cool to sort our local playlist, because when you have a lot of it its kinda messy. If someone would like to do that, I would advise him/her not to do folders, but things more like the animation used for "import export" in the sub page for each new category created by the user.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Stypox commented 5 years ago

Related (with discussion): https://github.com/TeamNewPipe/NewPipe/issues/1982#issuecomment-528029200

MD77MD commented 4 years ago

@Stypox https://github.com/TeamNewPipe/NewPipe/issues/1313#issuecomment-528029306... although I'm a fan of tags...I agree with you, folders make more sense here and alot easier to use too.

This would help organize all my playlist.. a special folder for all my music 🎶 playlists... I can even have it divided by artist, now that's cool 😎

justanidea commented 4 years ago

Damn, the me of 2 years ago had such a good idea :o And @MD77MD is on the same direction as me, i was thinking in sorting my musics too when writing this post (i usually get 1000 more musics each year...)

MD77MD commented 4 years ago

this is the kind of small features which reviels how stupid and manipulative YouTube is -aka Google- and once someone tires them, can never go back to the YouTube app

cntrl-s commented 3 years ago

@Stypox @MD77MD is someone working on this?

i want to try to implement this

Stypox commented 3 years ago

@cntrl-s No, nobody is working on this at the moment, so feel free to pick it up! Thank you :-D Before taking ui / usability design decisions I suggest you to get some feedback here, so that you won't have to make more changes later ;-)

cntrl-s commented 3 years ago

@Stypox

Before taking ui / usability design decisions I suggest you to get some feedback here, so that you won't have to make more changes later ;-)

i will, thank you :)

MD77MD commented 3 years ago

@cntrl-s any update?

i don't know coding but I can help with testing and feedback.

cntrl-s commented 3 years ago

@MD77MD i am new to android development so this will take a while

i will let you know once i have something for you to test :P

cntrl-s commented 3 years ago

@MD77MD @Stypox how do you think we should implement playlist group view

i am thinking horizontally scrollable (like feed group) under playlist tab with thumbnail of first playlist under the group as thumbnail for the group

XiangRongLin commented 3 years ago

@cntrl-s I would do it like the channel groups/subscription groups. So the current playlist view gets expanded by a header to manage the groups. When clicking on one of those groups it opens the old playlist overview with all the playlists in that group. From there you can open a single playlist to see the single videos.

It would allow to reuse/copy stuff, depending if you want to extract out common components or just copy over what you need. Restriction would be that you can only have 1 layer and thus can't have nested groups, like a traditional file system. But i dare say that multilayer approach is a lot harder and not necessary.

cntrl-s commented 3 years ago

But i dare say that multilayer approach is a lot harder and not necessary.

@XiangRongLin i agree with this, i was thinking we could have simple groups like subscription groups

tsilvs commented 3 years ago

JSON / YAML import / export of playlists feature would also be nice.

And maybe an archiving feature per playlist?

Guess I'll describe these ideas in separate issues, but they should be considered in possible playlists tab redesign.

Stypox commented 3 years ago

i agree with this, i was thinking we could have simple groups like subscription groups

@cntrl-s I also agree, but I'd use the group's thumbnail as a background image for the group item. Also, I'd make the playlist group items have: a height that is something in between 1.5x and 2x the height of subscription group items; a width/height ratio of 16:9.

Guess I'll describe these ideas in separate issues,

@JeffRockatansky yeah, those are different and unrelated proposals

cntrl-s commented 3 years ago

@cntrl-s I also agree, but I'd use the group's thumbnail as a background image for the group item.

@Stypox that's what i said in a reply above we could use the thumbnail of the first playlist under the group as thumbnail for the group or we could combine different playlists thumbnail to make a new one (vlc android does this for folder with multiple videos)

Stypox commented 3 years ago

@cntrl-s if this does not require storing too much cached data on the user's phone then ok

cntrl-s commented 3 years ago

@Stypox ok i will start working on this, thank you

Stypox commented 3 years ago

@cntrl-s thanks to you! :-D

cntrl-s commented 3 years ago

@JeffRockatansky @Stypox @MD77MD @XiangRongLin how do you think the playlist selection view should be when selecting playlists for a group

should every playlist have a radio button or have a ':white_check_mark:' on top of selected playlists or something else

XiangRongLin commented 3 years ago

I personally don't care too much about it. Try to make it simple and close to the existing channel groups.

So a list where if one entry is selected the thumbnail is covered my a ✔,would be the simplest that i can think of right now

tsilvs commented 3 years ago

@cntrl-s a tick over a playlist is good. Radio will take too much additional space. You could even dim selected list elements in addition to a check mark.

Maybe you could also try implementing paths while naming a playlist? E.g. when you type Parent/Child or Parent.Child (or with any other custom delimiter) then playlist Child is moved into playlist Parent, so the tree could look like this:

Parent
├ Child
│ └ [videos]
â”” [videos]

Parsing existing names would also be very much appreciated, especially because my playlists all look like _sw.os.linux.arch, _sci.phys.quant etc, and I have over 100 playlists already)))

In case of parsing a path, you should also consider and process certain delimiter edge cases:

XiangRongLin commented 3 years ago

@JeffRockatansky Im going to give this a hard NO, because this is complex enough as is.

Please open a seperate issue if you want the feature.

tsilvs commented 3 years ago

@XiangRongLin ok, I get it.

What about the structure of folders itself?

Should a folder contain:

XiangRongLin commented 3 years ago

https://github.com/TeamNewPipe/NewPipe/issues/1313#issuecomment-767414178

tsilvs commented 3 years ago

@XiangRongLin could you explain in detail why multilayer is harder? And why do you think it's not necessary?

XiangRongLin commented 3 years ago

@XiangRongLin could you explain in detail why multilayer is harder? And why do you think it's not necessary?

Because its multiple layers, meaning more stuff to do. More changes need to be made to the data model, the logic and the representation. More needs to be tested and more code needs to be reviewed. Overall its more work, which can be split up into multiple feature request and multiple PR

cntrl-s commented 3 years ago

@JeffRockatansky i will implement it with dim and a tick

cntrl-s commented 3 years ago

Because its multiple layers, meaning more stuff to do. More changes need to be made to the data model, the logic and the representation. More needs to be tested and more code needs to be reviewed. Overall its more work, which can be split up into multiple feature request and multiple PR

also we have to keep track of both local and remote playlists within the folder structure which would be very complex to design database for and this would be even harder as sqlite doesn't support constraints on the database table, we probably would have to keep track of local and remote playlists separately

Sam4000der3 commented 2 years ago

I'm still hope for this feature. I have to much playlists. I hope to filter my playlists by genre (music playlists) and language.

MD77MD commented 2 years ago

any luck with this?

Sam4000der3 commented 2 years ago

any luck with this?

Noop. Unfortunately not

RohitSingh107 commented 1 year ago

Any progress on this?