TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.59k stars 3.07k forks source link

Youtube Music link support #3073

Closed champion174 closed 4 years ago

champion174 commented 4 years ago

Please include YouTube music in newpipe, just like you've added SoundCloud, Mediacloud and some others.it'll help a lot I hope your dedication can do this.

gkeegan commented 4 years ago

Not sure about the difficulty of making YouTube Music into it's own tab, but YouTube Music videos/audios would be a simple implementation I believe.

Take this track: https://music.youtube.com/watch?v=9XvXF1LrWgA&list=PLrEnWoR732-DtKgaDdnPkezM_nDidBU9H

If you remove the music and the &list=PLrEnWoR732-DtKgaDdnPkezM_nDidBU9H, you just get the singular track on YouTube, which could then be downloaded.

I've wanted to get more involved with the code aspect of NewPipe, so I would like to attempt to add this as a link handler via the extractor.

gkeegan commented 4 years ago

If you could test the apk in #3074 that would be appreciated. It seems like there was already stuff for YouTube Music in the extractor, so I don't think I'll have much work to do.

B0pol commented 4 years ago

Also, playlists generated from YouTube Music are not handled. https://music.youtube.com/playlist?list=PL4fGSI1pDJn5Je5NXSbA_Y-pSwa16FntZ If you share this to newpipe, it crashes, it should give top 100 tracks in the world.

PeterHindes commented 4 years ago

Youtube Music Links Are supported in 18.6 latest release. Just share your albums from the youtube music app.

B0pol commented 4 years ago

It should be reopened, it's not supported by the manifest file, then it opens in browser instead of NewPipe. Once this is achieved, we can say NewPipe supports YouTube music links

wb9688 commented 4 years ago

@B0pol: I already noticed and re-opened ;)

wb9688 commented 4 years ago

See #3177

opusforlife2 commented 4 years ago

I think Youtube Music should be a separate entry in the service selector. Since the focus is on audio, it should have a Soundclound-like UI, where only background playback is available. Video playback is a waste of data in this case.

B0pol commented 4 years ago

I think Youtube Music should be a separate entry in the service selector. Since the focus is on audio, it should have a Soundclound-like UI, where only background playback is available. Video playback is a waste of data in this case.

I don't think so. There are videos on music, clips. Why would you want to block videos when you have the possibility to play audio only?

wb9688 commented 4 years ago

YouTube Music is only another UI for YouTube, and has the same streams and everything, just a different search engine, which we should add to NPE. There is no need for it to be a separate service in NPE.

opusforlife2 commented 4 years ago

Hmm. Are these videos separate from the ones accessible from the main Youtube site? If not, then the user could access them from there, no?

wb9688 commented 4 years ago

No, it has the same videos you could also access from YouTube's main site.

opusforlife2 commented 4 years ago

I suppose if the UI clearly categorises songs separately from videos, anything would be fine.

opusforlife2 commented 4 years ago

If you were to tap on the thumbnail of an audio, though, what should happen? Should it play audio only, or the video as well? The video is just the thumbnail in all the frames.

PeterHindes commented 4 years ago

Youtube musics main feature is the search and likes are filtered to only include songs. It also includes automatic playlists for albums of supported artists.

jlpalaciosb commented 4 years ago

Yes Peter, NewPipe should prioritize Youtube Music results

PeterHindes commented 4 years ago

No it should be an option to use results from each search provider.

On Sat, Mar 14, 2020 at 6:00 PM jlpb97 notifications@github.com wrote:

The app should prioritize YOUTUBE MUSIC results

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TeamNewPipe/NewPipe/issues/3073#issuecomment-599149561, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEYRO5Z7SPFE65LMKPAZSOTRHQLCRANCNFSM4KSY2YJA .

jlpalaciosb commented 4 years ago

Yes Peter, I think that is a better approach

B0pol commented 4 years ago

It's now supported.