Crash / strange behaviour when opening closed play queue from recent apps

TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.

https://newpipe.net

GNU General Public License v3.0

31.25k stars 3.03k forks source link

Crash / strange behaviour when opening closed play queue from recent apps #3200

Open opusforlife2 opened 4 years ago

opusforlife2 commented 4 years ago

[x] I checked if the issue/feature exists in the latest version.
Play an audio in the background player.
Back out of the app entirely.
Open the Background Player by tapping the notification.
Back out of it.
Stop the video from the notification.
Try to open the player from Recents.

Stypox commented 4 years ago

I did not understand what the problem is :sweat_smile:

wb9688 commented 4 years ago

Could confirm.

@Stypox: See this video: recording_20200308_172127.mp4.zip

opusforlife2 commented 4 years ago

Whoa. Crash if you try the same thing with the popup player.

Attempt to invoke virtual method something.something.getRootView() on a null object reference.

PeterHindes commented 4 years ago

This might also be related to a minor issue i was having. Some launchers like niagara, have a built in widget for music players. However when you tap to open the associated app, it cant find newpipe.

opusforlife2 commented 4 years ago

Still exists on 0.19.8.

Stypox commented 4 years ago

Fixed in unified player / notification improvements (I just tested on Android 7.0, reopen if I'm wrong)

opusforlife2 commented 4 years ago

Still happening for me. If you're trying on your Huawei, maybe that handles it differently?

opusforlife2 commented 4 years ago

Basically, the app should either:

remove the background/popup player queue activity from Recents when the stream is killed from the notification, or
open Newpipe's main activity instead

One example of something similar happening is when you have App Info open for any app, and you delete the app through Play Store or F-Droid, Android removes the App Info activity from Recents as well, because there is no app whose information can be shown anymore.

Stypox commented 4 years ago

Oh yeah, I am on Huawei and it open Newpipe's main activity

opusforlife2 commented 4 years ago

I did not understand what the problem is 😅

No wonder, then. xD

opusforlife2 commented 3 months ago

New behaviour! There is no longer a crash/strange behaviour trying to do this.

However, it's debatable if what happens is strange too: Newpipe opens the queue, but it's completely empty. Never seen that screen before. Almost like an easter egg. Normally when you empty the queue the activity auto-closes.