Closed ghost closed 4 years ago
I could confirm it. I'll look into it tomorrow.
I did a git bisect
and it's caused by fda5405e48f7cb1f4f4b9df89052d55c90e8b167 (i.e. my Checkstyle fixes) :/
Edit: And it's not caused by the changes in DownloadDialog
or VideoDetailFragment
…
Edit 2:
```
----- pid 3360 at 2020-05-18 11:10:37 -----
Cmd line: org.schabi.newpipe.debug
Build fingerprint: 'samsung/a50eea/a50:10/QP1A.190711.020/A505FNXXS4BTCA:user/release-keys'
ABI: 'arm64'
Build type: optimized
Zygote loaded classes=9292 post zygote classes=3819
Dumping registered class loaders
#0 dalvik.system.PathClassLoader: [], parent #1
#1 java.lang.BootClassLoader: [], no parent
#2 dalvik.system.PathClassLoader: [/data/app/org.schabi.newpipe.debug-U6fxmCzuuAldIhImuSdZKQ==/base.apk:/data/app/org.schabi.newpipe.debug-U6fxmCzuuAldIhImuSdZKQ==/base.apk!classes2.dex:/data/app/org.schabi.newpipe.debug-U6fxmCzuuAldIhImuSdZKQ==/base.apk!classes3.dex:/data/app/org.schabi.newpipe.debug-U6fxmCzuuAldIhImuSdZKQ==/base.apk!classes4.dex], parent #1
Done dumping class loaders
Intern table: 40740 strong; 498 weak
JNI: CheckJNI is on; globals=945 (plus 37 weak)
Libraries: libandroid.so libandroid_runtime.so libcompiler_rt.so libjavacore.so libjavacrypto.so libjnigraphics.so libmedia_jni.so libopenjdk.so libsoundpool.so libwebviewchromium_loader.so (10)
Heap: 24% free, 7927KB/10MB; 141246 objects
Dumping cumulative Gc timings
Start Dumping histograms for 5 iterations for concurrent copying
ProcessMarkStack: Sum: 214.787ms 99% C.I. 10.506ms-128.800ms Avg: 42.957ms Max: 130.843ms
ScanImmuneSpaces: Sum: 50.885ms 99% C.I. 3.084ms-19.466ms Avg: 10.177ms Max: 19.466ms
VisitConcurrentRoots: Sum: 20.464ms 99% C.I. 1.398ms-11.200ms Avg: 4.092ms Max: 11.209ms
ClearFromSpace: Sum: 15.059ms 99% C.I. 0.744ms-5.910ms Avg: 3.011ms Max: 5.910ms
FlipOtherThreads: Sum: 6.440ms 99% C.I. 0.200ms-4.843ms Avg: 1.288ms Max: 4.934ms
SweepSystemWeaks: Sum: 3.725ms 99% C.I. 161us-2000us Avg: 745us Max: 2000us
GrayAllDirtyImmuneObjects: Sum: 3.185ms 99% C.I. 321us-1572.500us Avg: 637us Max: 1598us
EnqueueFinalizerReferences: Sum: 2.892ms 99% C.I. 85us-1816.250us Avg: 578.400us Max: 1820us
SweepLargeObjects: Sum: 2.710ms 99% C.I. 28us-2058.750us Avg: 542us Max: 2080us
ProcessReferences: Sum: 2.385ms 99% C.I. 5us-1354us Avg: 238.500us Max: 1354us
InitializePhase: Sum: 2.275ms 99% C.I. 119us-1565us Avg: 455us Max: 1596us
ThreadListFlip: Sum: 1.624ms 99% C.I. 91us-933.750us Avg: 324.800us Max: 945us
ForwardSoftReferences: Sum: 1.545ms 99% C.I. 100us-764us Avg: 309us Max: 764us
EmptyRBMarkBitStack: Sum: 1.099ms 99% C.I. 145us-337us Avg: 219.800us Max: 337us
VisitNonThreadRoots: Sum: 985us 99% C.I. 105us-347us Avg: 197us Max: 347us
ResumeOtherThreads: Sum: 955us 99% C.I. 3us-903us Avg: 191us Max: 903us
RecordFree: Sum: 608us 99% C.I. 68us-288us Avg: 121.600us Max: 288us
CopyingPhase: Sum: 526us 99% C.I. 33us-183us Avg: 105.200us Max: 183us
(Paused)GrayAllNewlyDirtyImmuneObjects: Sum: 489us 99% C.I. 67us-144us Avg: 97.800us Max: 144us
(Paused)ClearCards: Sum: 274us 99% C.I. 1us-11us Avg: 2.382us Max: 11us
ReclaimPhase: Sum: 265us 99% C.I. 23us-81us Avg: 53us Max: 81us
SweepAllocSpace: Sum: 262us 99% C.I. 27us-112us Avg: 52.400us Max: 112us
ResumeRunnableThreads: Sum: 252us 99% C.I. 21us-114us Avg: 50.400us Max: 114us
ClearRegionSpaceCards: Sum: 210us 99% C.I. 32us-66us Avg: 42us Max: 66us
MarkZygoteLargeObjects: Sum: 189us 99% C.I. 20us-77us Avg: 37.800us Max: 77us
MarkStackAsLive: Sum: 166us 99% C.I. 21us-48us Avg: 33.200us Max: 48us
FlipThreadRoots: Sum: 115us 99% C.I. 7us-58us Avg: 23us Max: 58us
(Paused)SetFromSpace: Sum: 107us 99% C.I. 6us-37us Avg: 21.400us Max: 37us
SwapBitmaps: Sum: 82us 99% C.I. 9us-38us Avg: 16.400us Max: 38us
(Paused)FlipCallback: Sum: 79us 99% C.I. 8us-29us Avg: 15.800us Max: 29us
Sweep: Sum: 65us 99% C.I. 10us-21us Avg: 13us Max: 21us
UnBindBitmaps: Sum: 14us 99% C.I. 2us-5us Avg: 2.800us Max: 5us
Done Dumping histograms
concurrent copying paused: Sum: 2.506ms 99% C.I. 202us-1076us Avg: 501.200us Max: 1076us
concurrent copying freed-bytes: Avg: 5057KB Max: 9517KB Min: 1117KB
Freed-bytes histogram: 640:1,3840:2,5760:1,8960:1
concurrent copying total time: 334.718ms mean time: 66.943ms
concurrent copying freed: 226419 objects with total size 24MB
concurrent copying throughput: 677901/s / 73MB/s per cpu-time: 105278081/s / 100MB/s
Average major GC reclaim bytes ratio 40.6948 over 5 GC cycles
Average major GC copied live bytes ratio 0.0218892 over 241 major GCs
Cumulative bytes moved 22180856
Cumulative objects moved 364032
Peak regions allocated 455 (113MB) / 1024 (256MB)
Total time spent in GC: 334.718ms
Mean GC size throughput: 53MB/s
Mean GC object throughput: 675975 objects/s
Total number of allocations 367507
Total bytes allocated 25MB
Total bytes freed 17MB
Free memory 2557KB
Free memory until GC 2557KB
Free memory until OOME 248MB
Total memory 10MB
Max memory 256MB
Zygote space size 1696KB
Total mutator paused time: 2.506ms
Total time waiting for GC to complete: 400.384us
Total GC count: 5
Total GC time: 334.718ms
Total blocking GC count: 0
Total blocking GC time: 0
Histogram of GC count per 10000 ms: 0:1,4:1
Histogram of blocking GC count per 10000 ms: 0:2
Native bytes total: 50831824 registered: 475600
Total native bytes at last GC: 58853472
/system/framework/oat/arm64/android.hidl.base-V1.0-java.odex: speed
/system/framework/oat/arm64/android.hidl.manager-V1.0-java.odex: speed
Current JIT code cache size: 570KB
Current JIT data cache size: 318KB
Current JIT mini-debug-info size: 69KB
Current JIT capacity: 2048KB
Current number of JIT JNI stub entries: 0
Current number of JIT code cache entries: 1003
Total number of JIT compilations: 1096
Total number of JIT compilations for on stack replacement: 28
Total number of JIT code cache collections: 8
Memory used for stack maps: Avg: 165B Max: 8136B Min: 16B
Memory used for compiled code: Avg: 612B Max: 20KB Min: 4B
Memory used for profiling info: Avg: 136B Max: 11KB Min: 24B
Start Dumping histograms for 2203 iterations for JIT timings
Compiling: Sum: 1.444s 99% C.I. 0.157ms-23.208ms Avg: 1.313ms Max: 53.374ms
Generate JIT debug info: Sum: 226.847ms 99% C.I. 25us-8303.999us Avg: 206.977us Max: 23366us
TrimMaps: Sum: 69.257ms 99% C.I. 26us-701us Avg: 63.018us Max: 1556us
Code cache collection: Sum: 4.398ms 99% C.I. 205us-1215us Avg: 549.750us Max: 1215us
Done Dumping histograms
Memory used for compilation: Avg: 73KB Max: 3940KB Min: 15KB
ProfileSaver total_bytes_written=14862
ProfileSaver total_number_of_writes=1
ProfileSaver total_number_of_code_cache_queries=1
ProfileSaver total_number_of_skipped_writes=0
ProfileSaver total_number_of_failed_writes=0
ProfileSaver total_ms_of_sleep=44999
ProfileSaver total_ms_of_work=33
ProfileSaver max_number_profile_entries_cached=0
ProfileSaver total_number_of_hot_spikes=32
ProfileSaver total_number_of_wake_ups=5
suspend all histogram: Sum: 13.073ms 99% C.I. 4us-1878.720us Avg: 52.927us Max: 2165us
DALVIK THREADS (44):
"main" prio=5 tid=1 Runnable
| group="main" sCount=0 dsCount=0 flags=0 obj=0x72415f98 self=0x7fad292000
| sysTid=3360 nice=0 cgrp=default sched=0/0 handle=0x7fae800ee8
| state=R schedstat=( 53098540187 403738437 1803 ) utm=5261 stm=48 core=3 HZ=100
| stack=0x7fcaba8000-0x7fcabaa000 stackSize=8192KB
| held mutexes= "mutator lock"(shared held)
at org.schabi.newpipe.util.ListHelper.getHighestQualityAudioIndex(ListHelper.java:282)
at org.schabi.newpipe.util.ListHelper.getDefaultAudioFormat(ListHelper.java:100)
at org.schabi.newpipe.download.DownloadDialog.onViewCreated(DownloadDialog.java:253)
at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManagerImpl.java:892)
at androidx.fragment.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManagerImpl.java:1238)
at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManagerImpl.java:1303)
at androidx.fragment.app.BackStackRecord.executeOps(BackStackRecord.java:439)
at androidx.fragment.app.FragmentManagerImpl.executeOps(FragmentManagerImpl.java:2079)
at androidx.fragment.app.FragmentManagerImpl.executeOpsTogether(FragmentManagerImpl.java:1869)
at androidx.fragment.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManagerImpl.java:1824)
at androidx.fragment.app.FragmentManagerImpl.execPendingActions(FragmentManagerImpl.java:1727)
at androidx.fragment.app.FragmentManagerImpl$2.run(FragmentManagerImpl.java:150)
at android.os.Handler.handleCallback(Handler.java:883)
at android.os.Handler.dispatchMessage(Handler.java:100)
at android.os.Looper.loop(Looper.java:237)
at android.app.ActivityThread.main(ActivityThread.java:7814)
at java.lang.reflect.Method.invoke(Native method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1075)
"Signal Catcher" daemon prio=5 tid=7 Runnable
| group="system" sCount=0 dsCount=0 flags=0 obj=0x13881740 self=0x7fad40e000
| sysTid=3374 nice=0 cgrp=default sched=0/0 handle=0x7f1bf20d50
| state=R schedstat=( 35129615 1894808 13 ) utm=1 stm=1 core=1 HZ=100
| stack=0x7f1be2a000-0x7f1be2c000 stackSize=991KB
| held mutexes= "mutator lock"(shared held)
native: #00 pc 000000000040d85c /apex/com.android.runtime/lib64/libart.so (art::DumpNativeStack(std::__1::basic_ostream
Edit 3: It's caused by the changes in ListHelper
. Redoing the Checkstyle fixes for that should fix the issue.
@eladkarako: Not really. I just ran ./gradlew installDebug
every time and checked on my phone whether the issue was happening. Obviously I also had to uninstall the app a few times, as you can't install an app with a lower version code.
Switching to any instance of peertube (I'm using for example https://peertube.social), clicking on the download button halts the entire application.
b.t.w. Its not related to way the content actually downloads (standard/storage access framework) since it happens in both ways the download is configured. Probably earlier in the resource fetching cycle.
It used to work fine two versions ago.