search

TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.07k stars 3.02k forks source link

Video/Popup playback for audio services (Soundcloud, Bandcamp) #4105

Open opusforlife2 opened 4 years ago

opusforlife2 commented 4 years ago

(Why is it that when you investigate one issue, you start discovering more and more of them!?)

  1. In the current release (0.19.8) Playlist and Channel pages on audio services show the Play All and Popup buttons, and these work. They show the thumbnail and play just the audio. This video player and this popup player is not accessible from the main video details page. Bug, since these are audio only services. There is no use of the popup or main player.

These two buttons should not be shown on the Playlist and Channel pages if the service is an audio service.

  1. In the unified player UI (post 2907), when you tap on the thumbnail on the video details page, the main player UI opens. This tap action is supposed to start background playback, like on 0.19.8. Instead, it does the same as (1). Shows a thumbnail and the main player UI. Bug, again, since these are audio only services.

Tapping on the thumbnail should start background playback, not main video playback. There is an awesome new progress indicator when playing background audio on audio services (edit: currently only SoundCloud), let's promote it more. ;)

opusforlife2 commented 4 years ago

Now I'm wondering if we could retain the main player UI for audio services. It looks neat, but the problem is that playback will stop if you have the Minimize setting set to None. Could Newpipe ignore that setting for audio services like Soundcloud and Bandcamp and just continue playing the audio?

avently commented 4 years ago

I always see No videos in SoundCloud tab so can't help you with this issue. Some years ago I was able to see SoundCloud but not now.

opusforlife2 commented 4 years ago

You mean the trending tab? Or does literally no video open for you, even through search or an external link?

avently commented 4 years ago

Without VPN it doesn't show anything (nor trading tab, nor artist page). With VPN it shows but slow. It's probably related to network providers in Russia (but the site itself works without VPN). So it's not important

opusforlife2 commented 4 years ago

That's quite strange that the site works but not Newpipe.

avently commented 4 years ago

Ok, I reread what you wrote and came to conclusion that I disagree with this issue. Let's see why:

Now I'm wondering if we could retain the main player UI for audio services. It looks neat

This is much better thought than in the first post:)

Could Newpipe ignore that setting for audio services like Soundcloud and Bandcamp and just continue playing the audio?

Could but why? Tap on "In background" instead of a player view and you'll get your background playback. What's a problem with it?

Stypox commented 4 years ago

I always see No videos in SoundCloud tab

This happens for me too, in Italy, on my phone and on 4.4 emulator, but not on 10 emulator

opusforlife2 commented 4 years ago

without background-only playback you can control playlist inside the player UI which is comfortable

Agreed.

popup is not needed and it doesn't show up now, which is good. But you may say why "Play in popup" inside channel exists. For situations when someone wants to see a thumbnail with ability to select next/previous track in a queue. And it looks better (three buttons vs two). Don't need it? Don't tap on it, easy:)

I agree. But with that logic, shouldn't popup also exist on the video details page? You could also want to play a song in a popup with auto-queue enabled.

Could but why? Tap on "In background" instead of a player view and you'll get your background playback. What's a problem with it?

Since it's an audio only service, I think it should behave like other apps which are for streaming music, and continue playback on switching away from the app. At first I thought that there could be a separate 'Minimize' setting for audio services, but that seems more complex than just checking if the service is an audio service and continuing playback.

wb9688 commented 4 years ago

@opusforlife2: What if you have a SC song then a YT vid queued?

opusforlife2 commented 4 years ago

I didn't even know that was possible!

... should that be possible?

wb9688 commented 4 years ago

@opusforlife2: Yes, YT also has songs and I might want to listen to songs from different services

opusforlife2 commented 4 years ago

This is like, the pro gamer league of Newpipe. Mixing and matching services in the quest for the ultimate queue/playlist/channel group.

opusforlife2 commented 4 years ago

Until now I've thought that Newpipe should have more separation between services. Not just searching, like now, but subscriptions, history, channel groups, tabs in the main fragment, etc.

Now I'm wondering how that would play out with service mixing.

... yeah, 'service mixing' sounds like a nice term for this concept.

avently commented 4 years ago

@opusforlife2 So what's the state of the issue after discussion?

opusforlife2 commented 4 years ago

Personally, I think we should postpone discussion about this issue until after 0.20.0 has been released. This is a UI/UX discussion so it will probably take time for us to find a good solution.

shouldn't popup also exist on the video details page? You could also want to play a song in a popup with auto-queue enabled.

Does anyone disagree with bringing back the popup button in audio services, though?

opusforlife2 commented 4 years ago

Why not go the tiny step further and retain the main player UI for video services as well when playing in background? It gives a way to control playback from within the app.