TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.24k stars 3.03k forks source link

Minimum brightness is brighter than just above minimum #4169

Open B0pol opened 4 years ago

B0pol commented 4 years ago

Version

-

Steps to reproduce the bug

  1. Open a video
  2. Lower the brightness to minimum
  3. Increase a bit brightness

Expected behavior

It's brighter than minimum

Actual behaviour

It's darker than minimum brightness

Screenshots/Screen recordings

Logs

opusforlife2 commented 4 years ago

4037, no?

litetex commented 2 years ago

https://github.com/TeamNewPipe/NewPipe/pull/4037#issuecomment-762704985

No longer a problem.

B0pol commented 2 years ago

The problem is still there with NewPipe 0.23.0.

litetex commented 2 years ago

The problem is still there with NewPipe 0.23.0.

Can't confirm.

  1. Set phone brightness to minimum
  2. Searched for a "black screen" video
  3. Opened the video in fullscreen mode
  4. Changed the brightness of the player to minimum → The same black value
  5. Increased the player brightness → Get's proportional brighter

So I guess it's maybe a OS/device problem?

B0pol commented 2 years ago

I do not put phone brightness to minimum first and I don’t need a black screen video, it works on all videos I tried by putting phone brightness to minimum as you said and I could not reproduce, minimum brightness is actual minimum brightness. I also tried putting phone brightness to maximum and player’s minimum brightness produces max brightness. Then I think player’s minimum brightness produces phone’s brightness instead of minimum brightness