search

TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
30.19k stars 2.97k forks source link

Limit number of downloads running in parallel #4215

Open KapilFaujdar opened 3 years ago

KapilFaujdar commented 3 years ago

Version

Steps to reproduce the bug

When multiple videos are downloaded. More than one video start downloading while the settings are configured to download one video at a time.

Expected behavior

Only one video should be downloaded.

Actual behaviour

Four videos from the queue start downloading simultaneously.

Screenshots/Screen recordings

Screenshot_20200903-092931055 Screenshot_20200903-092915826

Logs

opusforlife2 commented 3 years ago

Works fine here. Please provide additional info like device and Android version. And if you're using any VPNs or other network modifiers.

KapilFaujdar commented 3 years ago

Motorola G5 plus with Android 10.

Happens when many files are in queue and download is restarted after it was stopped manually or by network error.

opusforlife2 commented 3 years ago

Happens when many files are in queue and download is restarted after it was stopped manually or by network

See now this is something you should put in the template when you first open the issue. Otherwise the tester can be misled. Always give as much information as possible about your investigation into the problem.

opusforlife2 commented 3 years ago

and download is restarted

How are you restarting it? By tapping the play button in the top right corner? Or by tapping Start in that download's 3 dot menu?

KapilFaujdar commented 3 years ago

By tapping the button at top

opusforlife2 commented 3 years ago

Thought so. If you long press on the button you'll see that it's called Start Downloads. Which means it starts all the downloads at once. If you want to start a single download, you have to tap the Start option from its 3 dot menu.

@Stypox The idea makes sense. If a person enables the limit queue option, then that button should only restart the pending download and recreate the queue, instead of starting them all at once.

Also, the wording "Limit download queue" doesn't make sense. It should be called "Enable/disable parallel downloads". Limit queue would mean that we don't allow the user to queue more than x videos for downloading. That's not the case. The queue has no upper bound (I think).

NomarCub commented 1 year ago

Is there a ticket for an actual "Limit download queue" feature (as in limit them to a number)? I looked around, but the issues are a mess.

opusforlife2 commented 1 year ago

If you've searched for duplicates and not found any, you can always open a new issue.