search

TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
29.52k stars 2.95k forks source link

Change timestamp behavior #4241

Open snappyapple632 opened 3 years ago

snappyapple632 commented 3 years ago

Describe the feature you want

Timestamps should seek in the Unified Player instead of starting a pop-out player.

Is your feature request related to a problem? Please describe it

N/A

Additional context

N/A

How will you/everyone benefit from this feature?

Timestamp-based pop-out players are the inferior solution compared to instantly seeking in the unified player.

B0pol commented 3 years ago

why bug @opusforlife2 @TobiGr?

opusforlife2 commented 3 years ago

Unexpected behaviour compared to Youtube and Invidious?

opusforlife2 commented 3 years ago

That's how I differentiate between the two, anyway.

Bug: did something and got an unexpected result. Feature request: wanted to do something and was unable to do so.

B0pol commented 3 years ago

It is expected here. We did not change code about this therefore we do not expect the behavior to change.

opusforlife2 commented 3 years ago

You're speaking from the perspective of a developer here. There is probably no bug in the code, sure. But from a user's perspective, there is a bug in the behaviour. No user would tap on a timestamp and expect to see a popup of the same video. And it's not documented anywhere in the app that that's something that will happen. Any user who's used this functionality in Youtube or Invidious will expect to jump to that timestamp in the same video, though.

B0pol commented 3 years ago

But then by definition it's a request, feature request

And even as a user. I don't see the difference before and after unified player as you still can't view comments without popup player.

I don't want to scroll up to see the video after clicking on a timestamp, scroll down again for comments, scroll up for another timestamp…

YouTube is completely different because the video continues to play while viewing comments, that's basically our popup mode.

Compare YouTube:

And NewPipe:

The only way to reproduce youtube behavior is popup player

That's why we are launching popup player on timestamp and that's also why it shouldn't change

And please don't mention YouTube's desktop behavior, desktop ≠ mobile

opusforlife2 commented 3 years ago

It's definitely not a bug with the unified player, but existing behaviour from the past, so that should be removed from the title, I agree.

opusforlife2 commented 3 years ago

YouTube is completely different because the video continues to play while viewing comments, that's basically our popup mode.

Ah yes. I think avently was testing this out at some point, but it wasn't implemented. I forgot why.

I don't want to scroll up to see the video after clicking on a timestamp, scroll down again for comments, scroll up for another timestamp… YouTube is completely different because the video continues to play while viewing comments, that's basically our popup mode.

Would it not be possible to have the app 'jump' to the top upon tapping a timestamp?

I don't see why someone would tap several timestamps in a row, anyway. That seems like a corner case.

opusforlife2 commented 3 years ago

Also, how does this possibility sound? : If the video is paused, then it should scroll up just like it currently does, letting comments or suggested videos fill up the screen. But if the video is playing, then comments and videos should scroll under it.

snappyapple632 commented 3 years ago

I didn't see this as unintended behavior, that's why I posted this as a feature request. I felt this suggestion was more relevant and doable now that the player is going to work more like YouTube's. I honestly don't see the reason why timestamps have to make additional instances of the player if we already have a system that works in-line with the user interface.

My suggestion for the comments issue would be to compress the player about half it's height to the upper edge to make more room for the comments.

avently commented 3 years ago

@opusforlife2 let's see from a developer perspective. When you see that something you make has a label "bug" you think that you made something wrong and it's not make you happy. When you see a "feature request" it means that something new could be added and it's flne.

For you it may may sounds the same but because you don't write a code. It's like saying "a bug" when I disagree with your point in a comment:)

opusforlife2 commented 3 years ago

Fair enough.

Stypox commented 2 years ago

2851

triallax commented 2 years ago

@Stypox why did you close this instead of #2851? This issue has much more discussion surrounding it.

lomanq commented 2 years ago

Hi, i think that you can create an option in settings where the user can choose two differents method:

In this way the user can choose the best option for him.

What do you think about that?

sryze commented 2 years ago

How about this:

  1. Short tap on timestamp - fast forward to it in the existing player
  2. Long tap - do it in a popup player (current behavior)

?

yephny commented 2 years ago

That makes a lot of sense, sryze. Seems to offer the best of both worlds.

SameenAhnaf commented 2 years ago
  1. Short tap on timestamp - fast forward to it in the existing player

Keeping the video static while scrolling comments is a major feature and it'll be added anyway. https://github.com/TeamNewPipe/NewPipe/issues/4484 should be considered in this regard to make the feature useful on main player.

  1. Long tap - do it in a popup player (current behavior)

Long tap gesture should be preserved for copying links in comments and description as suggested in https://github.com/TeamNewPipe/NewPipe/issues/7097 and https://github.com/TeamNewPipe/NewPipe/issues/7378. Popup player will be required no more if my first suggestion is implemented, I think.

goyalyashpal commented 2 years ago

Popup player will be required no more if my first suggestion is implemented, I think.

link?

SameenAhnaf commented 2 years ago

@yashpalgoyal1304 https://github.com/TeamNewPipe/NewPipe/issues/4484

goyalyashpal commented 2 years ago

Would it not be possible to have the app 'jump' to the top upon tapping a timestamp? - https://github.com/TeamNewPipe/NewPipe/issues/4241#issuecomment-687777675

i dont think that that'd be a good idea

goyalyashpal commented 2 years ago

... cntd.

SomeoneIsWorking commented 2 years ago

This behavior got super weird lately. When you tap on a timespan it opens a popup player not from the timestamp but from the position you were watching. Then you can tap the timestamp again to make the popup player jump to that position. Then you can close the popup player and main player resumes from where popup player left. Doesn't resemble an intended behavior.

SameenAhnaf commented 2 years ago

@SomeoneIsWorking This issue is expected to continue playing timestamp on current player. Please have a look at https://github.com/TeamNewPipe/NewPipe/issues/7427 instead.

ghost commented 1 year ago

This behavior got super weird lately. When you tap on a timespan it opens a popup player not from the timestamp but from the position you were watching. Then you can tap the timestamp again to make the popup player jump to that position. Then you can close the popup player and main player resumes from where popup player left. Doesn't resemble an intended behavior.

same thing happens to me as well, except it takes around 8 seconds for the video to continue playing in popup mode and another 8 to go back to its original place

I think the video should jump to the intended timestamp when you press it, same way how it works across all other apps and frontends

goyalyashpal commented 1 year ago

So, one way - building on the one

  • but now after reading this explanation by bopol, the current popping up behaviour makes sense. at comment

one way to further improve further improve the experience using popup mode itself:

ONCLICK_TIMESTAMP( TIME )

1. IF current mode is not popup
2. THEN 
    + launch popup player with seek position at TIME with predefined:
    + ... size: best fit (i.e. for portrait: max width), 
    + ... and position: top most
    + ... in such a way that these predefined values doesn't override the 
      already saved user-adjusted popup player parameters
3. ELSE
   change the seek position in popup player to TIME
   END-IF
4. End
JakubFojtik commented 1 year ago

How about just letting users globally configure the player to be used for timestamp clicks? Would at least be useful for audio-only whole-album videos where timestamps seek to different songs. In this case users don't care about the video.

I tried changing InternalUrlsHandler.playOnPopup()`s playOnPopupPlayer to playOnMainPlayer, but that only resets the main player, so there must be some trick to it. playOnBackgroundPlayer works from the second time a timestamp is clicked, just like the popup player does: https://github.com/TeamNewPipe/NewPipe/issues/4241#issuecomment-1008154892.

The best solution seems to be figuring out the sticky video at the top if user wants it. Unlike the popup it would not obstruct content at the top of the page.

SameenAhnaf commented 1 year ago

The best solution seems to be figuring out the sticky video at the top if user wants it

You are right. https://github.com/TeamNewPipe/NewPipe/issues/4484 should be implemented before this issue. There's no need to make timestamp behavior customizable. Rather, continuous playback on current player is fine.

zynerd commented 1 year ago

I can't believe this is still an issue... As someone who uses timestamps a lot it's been a real hassle to have to close the popup viewer every single time I click on a timestamp. As far as I'm aware, it doesn't look like #4484 is being worked on either⁠—which could have justified the lack of attention to this issue. I really like NewPipe but this is one of those things that makes me want to move to a different app.

adamency commented 9 months ago

Can you please acknowledge this issue ? Besides discussions about bug vs feature, you can clearly see how this is a counterintuitive and confusing behavior for the majority of users: this is the 12th most upvoted open issue and more than 10 duplicate issues of this have already been opened. And in the top 20, this seems to be the only one that would need a very minor patch to complete (along with #4478).

@B0pol The argument of "If we're reading the comments and clicking on a timestamp, we still want to read the comments so we need to open the video in a pop-up" is a classic example of theoretical developer thinking without practical functional testing. When the video is already playing somewhere and the user clicks a timestamp, they're expecting the current player to simply jump to the timestamp only, without the UI layout changing. Clicking a timestamp is an action on content, not UI.

goyalyashpal commented 9 months ago

When the video is already playing somewhere and the user clicks a timestamp, they're expecting the current player to simply jump to the timestamp only, without the UI layout changing.

no? at least i want the video to show up at times. but yeah, (neither this, nor ur assumption) fits all.

adamency commented 9 months ago

I will not debate on this, while what you're saying can be wanted (and for good reasons), statistically we can clearly see the majority opinion on this topic. I'll leave it at this.

PS: And in any case, making it a toggle would solve it for all.

yephny commented 9 months ago

@adamency In both issues, a toggle would be the ultimate solution as you said. Unfortunately, I doubt the reason we're not getting these features is that the developers are undecided. It's just that they're trying to keep up with the changes made to Youtube on the regular + fixing up bugs + rewriting the entire codebase. I'm not sure if they're going to make any improvements to the current app considering the last point.

KaKi87 commented 8 months ago

Maybe there should be two teams : one focused on scraping, the other focused on the rest.

foxjaw commented 2 months ago

@SameenAhnaf I don't see #4484. I think the user was bann3d or shadow3d. What was that issue ?

SameenAhnaf commented 2 months ago

@foxjaw You may keep an eye on https://github.com/TeamNewPipe/NewPipe/issues/5450 instead to track the same request. Thanks for letting us know about the problem.