Autoplay switch doesn't enqueue next video instantly

TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.

https://newpipe.net

GNU General Public License v3.0

29.51k stars 2.95k forks source link

Autoplay switch doesn't enqueue next video instantly #4242

Open vkay94 opened 3 years ago

vkay94 commented 3 years ago

Version

0.19.8 and Unified player test apk: https://github.com/TeamNewPipe/NewPipe/commit/a801d0994f6cc1fe246c0d5ffff98aed09888ea8 (2020-09-06)

Steps to reproduce the bug

Open any stream, keep playing (or stop it) and turn off Autoplay switch if not already disabled
Clear all streams (list icon in the player) if there are some in the queue
Turn on Autoplay switch

Expected behavior

The moment when the switch is turned on the playqueue icon (the one next to Playback Speed Controls) should appear and enqueue the next video.

Actual behaviour

After the switch event "nothing" happens until one of the following occurred afterwards:

play/pause button press
seek event (either timebar or double tap)
player recreation (e.g. orientation)

opusforlife2 commented 3 years ago

In testing this, I found that if 'autoplay next stream' is toggled on, removing the upcoming stream just results in the same stream being added again. Is this expected behaviour? Seems like it should look for another stream. Or the stream shouldn't be swipe-able to show that it can't change, if that is the case.

vkay94 commented 3 years ago

I've also seen this behavior and I agree with you that the next stream shouldn't be swipe-able if autoplay is enabled. But I wouldn't add the next stream at all. Instead, when the video finishes, I would check whether there are other streams and if there are streams, play it, otherwise play the recommended one + add it to the list. What do you think?

By the way, I've encountered another bug in connection to the unified player + playqueue. Should I open another issue? (I mean it's still WIP ...)

opusforlife2 commented 3 years ago

This mechanism is similar to #3416 in that tapping certain buttons causes the app to react properly.

opusforlife2 commented 3 years ago

What do you think?

I think it is better to show the upcoming stream in some way.

opusforlife2 commented 3 years ago

By the way, I've encountered another bug in connection to the unified player + playqueue. Should I open another issue? (I mean it's still WIP ...)

Confirm that it doesn't happen in 0.19.8, first. You didn't do that here, and the unified player label was misleading. If it is specific to the unified player, then open an issue saying that, because the unified player should be as well received as possible. Users are anyway going to complain about the big change, so we should minimize that.

If it is present in 0.19.8, then you should open an issue anyway, after checking for duplicates.

vkay94 commented 3 years ago

You didn't do that here, and the unified player label was misleading.

That's not exactly true, we've just started to discuss another related issue here ;). My opening post is unified player exclusive since you can't toggle autoplay in v0.19.8 during main/fullscreen player (it's the only player type which can show the playqueue dialog as I see). But in the unified player test apk both can be visible at the same time.

If it is present in 0.19.8, then you should open an issue anyway, after checking for duplicates.

The issue I encountered is also related to the possibility to show the playqueue dialog and changing streams (I'll record a video then ;))

opusforlife2 commented 3 years ago

Oh. Nah. The queuing bug you see with the main player's queue is the same with the popup and background player queues. That's why I removed unified player from the title, and edited the OP to add 0.19.8, because it happens there as well.

So check your other issue against the background player in 0.19.8 to eliminate doubt.