search

TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.23k stars 3.03k forks source link

Add codec options to the player controls #4358

Open ghost opened 4 years ago

ghost commented 4 years ago

Disclaimer: I did not want to open 10 requests and bugs for essentially one thing when unified, namely: video stream options and quick settings.

Describe the feature you want

I would like to be able to choose the Audio and Video options like AVC, VP9, AV1 or 3GP, and AAC vs Opus, with their qualities on the fly. Now the option is solely set in the settings menu under audio and video. And It seems very restrictive aswell. When WEBM is set it only shows WEBM streams in the player.

Is your feature request related to a problem? Please describe it

Example Problems: 1) Settings related I want to set the standard to 2k60fps or 4k30fps, but it wont let me, even in the settings menu. I want to see every possibility. (24fps, 25fps and 50fps do not tell at all) 2) Codec related I want to watch some videos, but the ones that are both new and unpopular do not play in WEBM (vp9) #2415. I want to avoid codec specific artifacting. I want to listen to the best audio codec for the specific video. 3) End user problems I want to change to a lighter codec because my phone is hot. I want to save bandwidth. (wifi vs 4g or other people using the network and stuttering)

Additional context

This issue is related to: add option for bitrate for audio playback #1583, Codec selection instead of format #3159, and more settings related issues.

How will you/everyone benefit from this feature?

It will make the app more robust against server side changes and user situation side changes. For instance if a specific codec is served differently, or in the case that the end user situation changes.

Besides, I think this is nice todo when unifying things like done in the RC #4333.

Possible Implementation

I think the on the fly part is doable without introducing clutter: 1) Add buttons for each codec/container in the quality dropdown and serve the video quality/audio quality list of the chosen one. 2) A seperate dropdown from which you tick both the video codec and the audio codec.

opusforlife2 commented 4 years ago

It's not Youtube-specific.

shockergit commented 2 years ago

Please make this feature to select desired codec. i use a low end phone. if h264 is available it would have been nice.

opusforlife2 commented 2 years ago

@shockergit You're looking for #3159.

shockergit commented 2 years ago

@shockergit You're looking for #3159.

yes thanks

SyCoREAPER commented 11 months ago

@opusforlife2

Which is the correct one? Here you refer to #3159 and in 3159 you refer to here.

opusforlife2 commented 11 months ago

Here you refer to https://github.com/TeamNewPipe/NewPipe/issues/3159 and in 3159 you refer to here.

Can you link to that other comment?

SyCoREAPER commented 11 months ago

Here you refer to https://github.com/TeamNewPipe/NewPipe/issues/3159 and in 3159 you refer to here.

Can you link to that other comment?

I was either sleep deprived or can't read. Clearly wasn't you, you reopened it.

https://github.com/TeamNewPipe/NewPipe/issues/3159#issuecomment-701406731

I saw however that this is listed as niche and therefore assume it's not a priority at this time?

opusforlife2 commented 11 months ago

That issue is more important because current settings are somewhat obscure. This issue is a "nice to have", but putting even more settings into the player UI is always a challenge.

SyCoREAPER commented 11 months ago

That issue is more important because current settings are somewhat obscure. This issue is a "nice to have", but putting even more settings into the player UI is always a challenge.

I don't doubt it I can't remember if I posted here or on Reddit but a good source of inspiration would be Smart Tubes TV interface. Pretty clean way of selecting the codec, resolution, framerate ,etc all in one.

Obviously not suggesting ripping it off but worth mentioning.

Nalajalan commented 1 month ago

Ok, Hi everyone, and sorry for the almost double post. I'm not sure to understand why it seems didn't have evolved since 2020. The default quality choice is perhaps a not so easy question but the quality selection for video playing and downloading and audio background playing is... So did I miss something ?