Add the Switch to Pop-up/Background player buttons back

Kromppo commented 4 years ago

Checklist

[x] I checked, but didn't find any duplicates of this issue in the repo.
[x] I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
[x] This issue contains only one feature request. I will open one issue for every feature I want to request.

Describe the feature you want

Before update 20.0 there use to be certain buttons in the video player that or now missing. Where the open in youtube button is now, there used to be the background player and pop out button, along with a force video rotation button. The force rotation button was especially useful for watching vertical videos. I know that pop out and background player got moved below the video but it was easier to access these features when watching in full screen mode. Also, the video player doesn't automatically go to full screen in portrait orientation, so if that could be reverted.

Is your feature request related to a problem? Please describe it

These features are not problems, but a matter of convenience. Instead of leaving fullscreen to access them, there were right on the video player.

Additional context

Add any other context, like screenshots, about the feature request here

If you add this back I'll buy the devs big Macs.

How will you/everyone benefit from this feature?

This is a useful feature for users who watch videos in full screen mode, as most people do. Instead of exiting the video they can make adjustments from there and not ruin the emersion or viewing experience.

Flashwalker commented 3 years ago

Why devs always destroing our happy UX...

Flashwalker commented 3 years ago

fullscreen is activated automatically by rotating the device (if autorotation is active);

Sometimes autorotation fails in some devices or in UI firmwares

It is not very reliable to rely only on this sensor or someone else's code.

opusforlife2 commented 3 years ago

Why devs always destroing our happy UX...

@Flashwalker Yeah. Silly devs! I wonder who made the happy UX in the first place...

Oh. It was the same devs. xD

litetex commented 2 years ago

FYI: The background player and popup buttons are still accessible from the fullscreen/landscape player:

Long click the "more options" button

https://user-images.githubusercontent.com/40789489/140622614-0e775dec-6be3-45e4-a638-4baf39218246.mp4

Note: I found this by accident, maybe the UI should me more intuitive.

_{Can I get a "Big Mac" now?}

avently commented 2 years ago

@litetex

Note: I found this by accident, maybe the UI should me more intuitive.

Feel free to send a PR

opusforlife2 commented 2 years ago

@litetex @avently Is it possible to show tooltips for in-player buttons? We show a tooltip for the background and popup buttons explaining there is a long-press enqueue action available. Maybe something similar could be done for the 'more options' arrow. And maybe the full screen button also, explaining that it can be used to scroll down?

avently commented 2 years ago

The solution with a long click was made just to show the possibility to view everything under a video and it was a temporary solution.

I think more changes should be made in terms of player UI. I tried to add swipe from bottom to top in fullscreen that should trigger scrolling to comments but it looks bad with duration slider at the bottom.

So I would prefer if the duration slider goes up a little bit and top part of under video view goes up too. This will give the ability to tap and swipe to top. Similar to what official youtube has for mobile and for web in fullscreen.

This will fix the problem with touchable navigation area for Android with gestures and will fix the mentioned problem with swiping to the bottom.

opusforlife2 commented 2 years ago

What about a drag handle? We could put a small circle at the edge of the screen (on the left or right) which can be grabbed and used to scroll down. I think that will be a simpler solution, requiring much less effort, but being more obvious to the user as well.

We could even add an option in settings on where to place the drag handle, such as top-left, bottom-right, centre-left, etc.

avently commented 2 years ago

I don't think that drag handle is more obvious than drag handle + visible part of under player view. And my suggestion is also fixes the problem with a gesture navigation

opusforlife2 commented 2 years ago

visible part of under player view

But doesn't this interfere with full screen?

avently commented 2 years ago

Nope. Would be challenge to not make an ugly look of bottom player area since I can't imaging a good UI with such elements logic

Flashwalker commented 2 years ago

Nope. Would be challenge to not make an ugly look of bottom player area since I can't imaging a good UI with such elements logic

i can draw non-ugly look for you, good ui is not impossible with my ultra ux/ui design skill

comradekingu commented 2 years ago

@Flashwalker It would at least help the people playing at home to see what should be included. Changing bad design to good design is a lot easier than extracting good design from this thread.

TeamNewPipe / NewPipe