TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.59k stars 3.07k forks source link

Scroll comments/related streams under video #4484

Open opusforlife2 opened 4 years ago

opusforlife2 commented 4 years ago

Checklist

Describe the feature you want

When scrolling comments/related streams, the video should stay on screen and comments/streams should disappear under it.

Is your feature request related to a problem? Please describe it

People who are used to Youtube's behaviour find it very strange that the video scrolls as well.

Additional context

This is feedback I've gotten from a user.

Stypox commented 4 years ago

I think this was already discussed in #2907 and @avently was against it. I am personally in favour of this, but it would be really difficult to implement in a good way for every possible configuration of: vetical/horizontal video, landscape/portrait, fullscreen/not fullscreen, ...

opusforlife2 commented 4 years ago

It only has to happen for the player embedded in video details in portrait orientation, not full screen. In landscape, videos always play in full screen.

avently commented 4 years ago

@Stypox

really difficult to implement in a good way for every possible configuration of: vetical/horizontal video, landscape/portrait, fullscreen/not fullscreen,

yeah, I didn't think of it. Actually implementing like this would prevent from scrolling in fullscreen which is a useful thing now

Maxwell12347842 commented 4 years ago

i would love if this would be implemented again. i hated it after updating how it is now.. this & other things (design related) that got changed in the last update got me to downgrade again since i hate a lot of the new layout design decisions. it was better and more userfriendly before the last update IMHO.

skyGtm commented 3 years ago

@Stypox @opusforlife2 This will help https://github.com/TeamNewPipe/NewPipe/issues/5450#issuecomment-762596954

Dangelman commented 2 years ago

I like scrolling comments while viewing a video in portrait. Would def love to see this feature in NewPipe.

MD77MD commented 2 years ago

@opusforlife2 I think this should be added to Major planned/missing features #6448

MD77MD commented 2 years ago

I also strongly suggest for this to be optional in settings ... to accommodate all different devices and use cases.

opusforlife2 commented 2 years ago

@MD77MD It's not major because the functionality is present using the popup player workaround. This would be a convenience, certainly, but it's not 'missing'.

MD77MD commented 2 years ago

you have a point but as you said its way more convenient

jivemelon commented 2 years ago

are there any plans for this at all, or any time soon? I think using the popup player to achieve this functionality is a pretty hacky solution.

opusforlife2 commented 2 years ago

Nope. No one has volunteered to work on this, so far.

joshuabengal commented 1 year ago

Would like to see this implemented. Scrolling the video away when you read the comments is a poor user experience,

adamency commented 1 year ago

@Stypox yeah, I didn't think of it. Actually implementing like this would prevent from scrolling in fullscreen which is a useful thing now

Can you explain how you scroll while in full screen ? Cause I don't see any way to do this. This doesn't even seem to mean anything, as if you're reading comments you're by definition not in fullscreen.

And even if this is a thing, we simply have to activate this only in portrait mode, and keep the current behavior in landscape. Doesn't seem to be an obstacle.

MD77MD commented 1 year ago

I think this should be included in the rewrite

opusforlife2 commented 1 year ago

The rewrite is being done to make future development easier. So technically, all features that are left for after the rewrite are 'included' in it.

SyCoREAPER commented 10 months ago

I'm SyCoREAPER and I approve this message.

ReEnMikki commented 2 weeks ago

Someone please fork NewPipe and make this a feature. Bloody hell the fact that this is still not yet implemented is mind boggling.