TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.04k stars 3.01k forks source link

Access to private SoundCloud playlists with a "secret link" #4863

Open SpazMahTazz opened 3 years ago

SpazMahTazz commented 3 years ago

Checklist

Describe the feature you want

I'd like NewPipe to be able to read the "secret playlists" links you can create in SoundCloud. This feature would be similar to adding an "Unlisted" YouTube playlist.

Is your feature request related to a problem? Please describe it

The only workaround for this is to change the SoundCloud playlist to public, play the playlist on NewPipe, add the 'now playing' track list as a local playlist, then change the SoundCloud playlist back to private.

Additional context

I know it's possible to add public SoundCloud playlists in NewPipe, but I would love to create a private playlist in SoundCloud and use the secret link it generates. I tried copying the secret link and pasting it into NewPipe's search bar and it just shows the "No results" page. Making a private playlist with a secret link: https://imgur.com/a/l2SLF6I

How will you/everyone benefit from this feature?

You can browse SoundCloud on your browser, phone, etc, and add songs to your private playlists on the go which should then show up in NewPipe.

AudricV commented 2 years ago

Note that this also applies for albums (which are playlists) and tracks.

In my opinion, this should be easy to solve and would be a very great enhancement of the SoundCloud service on NewPipe!

Extractor changes are required in order to support the secret tokens on albums, playlists and tracks.

ghost commented 1 year ago

Hey, I am a student and a new contributor to the project, can I be assigned this issue? I have read the project documentation and contribution statements. Could you please give me some instructions and point me in the direction of where to find the classes (or folders) concerned with the problem

Thanks.

AudricV commented 1 year ago

Hi!

Thanks for looking into this enhancement. The changes which needs to be done are on the extractor repository, in the soundcloud package.

You probably need to make changes on SoundcloudPlaylistExtractor and its ListLinkHandlerFactory, SoundcloudPlaylistLinkHandlerFactory.

Don't hesitate to ask help, either here or on our IRC channel!

HotDryNoodle-WH commented 1 year ago

Hi, I'm currently working on this issue with u7283219, By modifying the URL pattern, it can recognize the private play list link, But the play list cannot be loaded

image

image It looks like the url id is not available.

In the Souncloud API document : image Does this mean we can't access the user private playlist, or is there any way to fix this?

Thank you!

opusforlife2 commented 1 year ago

@OneGuitars AudricV has answered you on IRC, but I'm repeating the advice here:

If so, you must not use the official API We are using SoundCloud's internal API You need to add &secret_token=SECRET_TOKEN to API queries

HotDryNoodle-WH commented 1 year ago

Could you tell me in which file to add &secret_token=SECRET_TOKEN to API queries?