Playlist playback consistency

rancidfrog commented 3 years ago

Checklist

[x] I am using the latest version - Version 0.20.2 x.xx.x
[x] I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
[x] I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
[x] This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

Open playlist with multiple entries
Click on a video or long press a video and select 'start playing on pop-up' or long press and select 'start playing at background'
For the first two, the app only plays selected/clicked video. Whereas background playback enqueues whole playlist playing selected files.

Actual behaviour

Clicking on a video or 'Start on pop-up' only plays selected file 'Start on background' enqueues playlist and plays selected file

Expected behavior

All three playback methods should have the same behaviour. And since we are in a playlist it should follow the behaviour of 'Start playing in background', where selected file is played and the whole playlist is queued

Screenshots/Screen recordings

Device info

Android version/Custom ROM version: 10 / LineageOS 17.1

opusforlife2 commented 3 years ago

Clicking on a video or 'Start on pop-up' only plays selected file

Start on popup enqueues the whole playlist for me and plays from the selected stream.

Clicking on a single video and having it play is expected behaviour.

What is not expected is that Start in Background/Popup enqueues the whole playlist.

rancidfrog commented 3 years ago

@opusforlife2 Yes, you are right. 'Start playing on pop-up' queues all playlist, too. Thank you for this correction I could not see playlist icon, which sometimes shows, sometimes not: i guess not on pop-up anymore, but clicking notification brings you to queue

Clicking on a video should enqueue whole playlist, too. As we are in playlist view, and clicking on an item should start playing item selected, but with loaded playlist (just like in youtube). That is the whole point of playlists.

Otherwise, 'Start playing in main player' is needed, with same behaviour as other 'start' buttons.

triallax commented 3 years ago

I am using the latest version - x.xx.x

@rancidfrog did you perhaps forget to replace this?

Stypox commented 3 years ago

Oh, there is an inconsistency here

rancidfrog commented 3 years ago

@Stypox When clicking a video in a playlist, it should queue the playlist. The long press menu work for pop-up and background. But the only way to trigger main video is by clicking on the video (no long press entry), and clicking does not queue playlist even though we are in playlist view ...

[Just like in youtube, even though this is not youtube, but with trending and similar videos etc it sure looks that way]

Thank you for your time

rancidfrog commented 3 years ago

Also, If you start playback, i.e. background from sharing to newpipe. Then it is not possible to add more videos to queue. As sharing again starts playing new video, And opening newpipe long press on a video does not offer enqueue, only start play video

dhruvpatidar359 commented 2 years ago

Hello , i think this is an interesting issue , i am ready to work on it , please assign me .

mayataylor233 commented 1 week ago

Hello, I'd like to work on this issue and I would appreciate if this issue was assigned to me.

Stypox commented 1 week ago

@mayataylor233 the project is currently undergoing a refactor and will not accept non-essential PRs for some time, especially on difficult topics like this one. The long-press menus and playlist headers will be rewritten completely and with a better behavioural design.

Thank you for your interest though, if you want to help take a look at https://github.com/TeamNewPipe/NewPipe/issues/11603 !

TeamNewPipe / NewPipe