search

TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.1k stars 3.02k forks source link

Limited time support for v0.19.8 #4918

Open XiangRongLin opened 3 years ago

XiangRongLin commented 3 years ago

I would be willing to provide a limited time support for NewPipe v0.19.8 while the issues with the new UI get addressed and I myself am comfortable to switch over. It would only contain updating the extractor version and fixing things if the public API of the extractor changes. No bugfixes specific to NewPipe and not NewPipeExtractor. Unless there are major changes in the extractor this would be ok for me since i plan to use it myself.

NewPipe and NewPipe Legacy.

https://github.com/XiangRongLin/NewPipe-preuinified/releases/

Legacy needs confirmation that it actually works

previous versions NewPipe v0.19.8 and Extractor v0.20.7 [app-release.zip](https://github.com/TeamNewPipe/NewPipe/files/5742289/app-release.zip) ------------------- NewPipe v0.19.8 and Extractor v0.20.6 [app-release.zip](https://github.com/TeamNewPipe/NewPipe/files/5680037/app-release.zip) https://github.com/XiangRongLin/NewPipe/commit/0feef16c9f0d17c49121e61be8576c238543df33 ------------------- NewPipe v0.19.8 and Extractor v0.20.5 with notification fixes for Android 11 [app-release.zip](https://github.com/TeamNewPipe/NewPipe/files/5652364/app-release.zip) https://github.com/XiangRongLin/NewPipe/commit/aa55a0987668e3d462e9fd50c2b7a9cc348fb468 ------------------- NewPipe v0.19.8 and Extractor v0.20.5 [app-release.zip](https://github.com/TeamNewPipe/NewPipe/files/5631523/app-release.zip) https://github.com/XiangRongLin/NewPipe/commit/4bca8f45fff777a9d003cfcf9876ec5497fb86b3 ------------------- NewPipe v0.19.8 and Extractor v0.20.4 with desugar/multidex changes for old devices [app-release.zip](https://github.com/TeamNewPipe/NewPipe/files/5617505/app-release.zip) https://github.com/XiangRongLin/NewPipe/commit/d3fe37216f61a27ac0b9be746e322f182d191348 ------------------- Release build with NewPipe v0.19.8 and Extractor v0.20.3 [app-debug.zip](https://github.com/TeamNewPipe/NewPipe/files/5566442/app-debug.zip) [app-release.zip](https://github.com/TeamNewPipe/NewPipe/files/5566443/app-release.zip) https://github.com/XiangRongLin/NewPipe/commit/e00a70682562ee693c2cd5dae886591c12c433fc ------------------- Debug build with NewPipe v0.19.8 and Extractor v0.20.2 [app-debug.zip](https://github.com/TeamNewPipe/NewPipe/files/5468966/app-debug.zip) The changes needed for this are: https://github.com/XiangRongLin/NewPipe/commit/e00a70682562ee693c2cd5dae886591c12c433fc
previous legacy versions NewPipe **legacy** v0.19.8 and Extractor v0.20.5 (needs confirmation thats it works on Android < 4.1) [app-release.zip](https://github.com/TeamNewPipe/NewPipe/files/5635343/app-release.zip) https://github.com/XiangRongLin/NewPipe-legacy/commit/7e150a64b52d1e6e19774133589c157589a33022
Wahbam commented 3 years ago

Thank you. 0.20.2 and 0.20.3 have been next to impossible to use for me due to constant crashes. Your debug build so far seems to work. Your 0.19.8 release build, however, for me fails to load any videos at all in search, trending, or (imported) subscription lists.

kubo6472 commented 3 years ago

Screenshot_20201119-121035_NewPipe pre-unified

XiangRongLin commented 3 years ago

@Wahbam

Thank you. 0.20.2 and 0.20.3 have been next to impossible to use for me due to constant crashes. Your debug build so far seems to work. Your 0.19.8 release build, however, for me fails to load any videos at all in search, trending, or (imported) subscription lists.

I can't really help you there. I generated the apks again and updated my post above.

@kubo6472 Also, can the "clear CAPTCHA cookies" option from 0.20.3 be added back into "content" tab. I have issues since it doesn't load.

no new features are getting backported

kubo6472 commented 3 years ago

no new features are getting backported

Aight, I understand.

kubo6472 commented 3 years ago

I can't really help you there. I generated the apks again and updated my post above.

The regenerated apk suddenly works no problem.

MD77MD commented 3 years ago

Although i don't plane to use it myself. this is very needed.

Thank you @XiangRongLin

triallax commented 3 years ago

How is this any different from #4686?

kubo6472 commented 3 years ago

How is this any different from #4686?

That the OA is the one who provided solution in that mentioned FR. This is just a separate issue to be pinned alone

opusforlife2 commented 3 years ago

Good point. This isn't a PR, but it 'fixes' that issue.

opusforlife2 commented 3 years ago

@eladkarako Your repo has no sources at all. You do know that it's illegal to distribute the binary without the source, right?

kapodamy commented 3 years ago

TL;TR the pre-unified version is not compatible with older devices.

Update the app/build.gradle file and include:

in the v0.19.8 version. because the lastest extractor aims the sdk v26 (android 8), See https://github.com/TeamNewPipe/NewPipeExtractor/pull/417.

edit: ¡the release apk is not signed!. wont install unless it is regenerated

BlueAmulet commented 3 years ago

I'm also unable to use this pre-unified version due to the lack of desugaring, if those commits could be added that would be appreciated.

@XiangRongLin

XiangRongLin commented 3 years ago

@kapodamy I can't get it to work by just cherry picking those 2 commits and merging them. I get an error when opening a video on api 19 emulator, that i won't make the effort to understand.

https://github.com/XiangRongLin/NewPipe/commit/d3d188854d2b05f8d534f4a539c0573faa5da55d

kapodamy commented 3 years ago

@XiangRongLin I added those commits and also made other changes (update kotlin) that I should have told you. I did a pr with the missing changes https://github.com/XiangRongLin/NewPipe/pull/3

XiangRongLin commented 3 years ago

@kapodamy I can't get it to work on the API 19 emulator with your changes. Is it something specific to the emulator?

kubo6472 commented 3 years ago

@kapodamy I can't get it to work on the API 19 emulator with your changes. Is it something specific to the emulator?

API 19 sounds a bit old, that may be caused by the JDK bump, since from what I found, they recommend JDK6 for widest compatibility on Android. @XiangRongLin

XiangRongLin commented 3 years ago

API 19 sounds a bit old, that may be caused by the JDK bump, since from what I found, they recommend JDK6 for widest compatibility on Android.

Im using it because its the minSDK of the project @kubo6472

kapodamy commented 3 years ago

@XiangRongLin i tested on 3 kitkat devices and works fine. Im getting this issue https://github.com/TeamNewPipe/NewPipe/issues/4957 only in the emulator. VirtualBox_andoid 4 4_29_11_2020_14_10_18 theres my build (but includes updates 3rd party libraries like exoplayer) wich i tested in the emulator and physical devices org.schabi.newpipe.preunified-1.zip

Isira-Seneviratne commented 3 years ago

@kapodamy I can't get it to work on the API 19 emulator with your changes. Is it something specific to the emulator?

API 19 sounds a bit old, that may be caused by the JDK bump, since from what I found, they recommend JDK6 for widest compatibility on Android. @XiangRongLin

Desugaring backports the JDK 8 types (the date/time API) for use on older versions of Android.

Isira-Seneviratne commented 3 years ago

@XiangRongLin i tested on 3 kitkat devices and works fine. Im getting this issue #4957 only in the emulator. VirtualBox_andoid 4 4_29_11_2020_14_10_18 theres my build (but includes updates 3rd party libraries like exoplayer) wich i tested in the emulator and physical devices org.schabi.newpipe.preunified-1.zip

Commit https://github.com/TeamNewPipe/NewPipe/pull/4921/commits/eb1cddd85aadc1c21f2c68cdd7904be6397384ef might fix this issue.

XiangRongLin commented 3 years ago

i tested on 3 kitkat devices and works fine. Im getting this issue #4957 only in the emulator.

@kapodamy ok, then its just the emulator. Also the reason for the apk not being signed could be because I only checked the v2 box when creating it. Now its with v1 and v2.

I updated my post with your changes.

@BlueAmulet fyi

nbmrjuhneibkr commented 3 years ago

Sadly, this build can't be used on Android 11, because old background player notification is completely broken there. So now I'm stuck with v0.20 (which hasn't been updated on F-Droid since 0.20.1, by the way). I had to stop using NewPipe for anything other than background playback (the only feature that isn't frustrating to use in 0.20, yet), and have no choice but to use a regular web browser for anything else.

I never thought that such a great app could become so useless so quickly. Thanks for keeping it alive on earlier Android versions, at least.

rikishi0071 commented 3 years ago

@XiangRongLin is it possible to build NewPipe Legacy 0.19.8 (Android 4.1) with NewPipe Extractor 0.20.x or not?

XiangRongLin commented 3 years ago

@rikishi0071 I just cherry-picked all commits. You'll have to hope that it works since i don't have a hardware device to test it in any way. And emulator doesnt work.

app-release.zip https://github.com/XiangRongLin/NewPipe-legacy/commit/7e150a64b52d1e6e19774133589c157589a33022

BlueAmulet commented 3 years ago

I get the same crash that happens in emulator, I'm running an Android Nougat 7.1 device

XiangRongLin commented 3 years ago

@nbmrjuhneibkr lucky you that i have android 11 too. check out the new apk at the top

nbmrjuhneibkr commented 3 years ago

@XiangRongLin it works now, thank you!

kubo6472 commented 3 years ago

I just wanted to really thank you for this one. For more than a month, I haven't had any issues with your builds, and didn't have to worry that suddenly these and these videos wouldn't play. This is as close to a finished app experience I can imagine. Since it's built on the old system everyone is used to, and just the backend is being adjusted, no big sudden changes, less stuff that can break etc. I appreciate the work guys did on the unified player, and how hard they worked on fixing everything, but that philosophically breaks use cases. Nvm, thanks again a have a nice Christmas eve day.

hipunk commented 3 years ago

Thank you, works great.

Isira-Seneviratne commented 3 years ago

@XiangRongLin I created a PR for your fork of NewPipe Legacy.

nbmrjuhneibkr commented 3 years ago

Thanks for the continuous updates. Seeing how little has been done to fix some of the terrible design decisions in NewPipe 0.20, I feel like this fork will stay relevant for quite some time.

nikhilCad commented 3 years ago

Months fly by, but v0.20 remains without option to stop autoplay, or playing in landscape without rotating phone.

XiangRongLin commented 3 years ago

I created a repo where i'll upload the releases from now on. So it's possible to just watch the releases of that repo in order to get notified.

https://github.com/XiangRongLin/NewPipe-preuinified/releases/

Multipanda commented 3 years ago

Thank you so much, the new UI has become more of a pain with each update so far, and unless they add an option to turn off the unified player I guess I will stick with your version as long as I can. :-)

Pavlecom commented 2 years ago

Thank you for your work !! ... 👍👍✨