TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.21k stars 3.03k forks source link

[Feature Request] Precise volume control #5063

Open RickyM7 opened 3 years ago

RickyM7 commented 3 years ago

Checklist

Describe the feature you want

It would be amazing to have a bar to precisely control the volume of the NewPipe. This feature is a "complement" to the #5061 feature because the two together would cause the NewPipe volume to be controlled regardless of the system volume.

Is your feature request related to a problem? Please describe it

Additional context

This is a complement of #5061, the two together would work better, I think.

About this feature: When you hold the mute button the volume bar would appear. In the background would have an option in the floating menu called "Volume Control" for this feature.

How will you/everyone benefit from this feature?

This feature would allow a more precise volume control, and if toged to the #5061 this would allow an independent volume control which is independent of the volume of the system, that's great in my opinion.

clicky6 commented 11 months ago

Do you mean like more precise volume adjustments; like in NewPipe currently I can increase or decrease volume but it is not precise, precise would be like out of 100 I can make minute adjustments like from 78 to 79 and so on. Like it is in Libretube?

https://github.com/TeamNewPipe/NewPipe/assets/89839714/dece9b50-7656-4a47-b551-1f4db25f47b9

RickyM7 commented 11 months ago

@clicky6 Basicaly yes, it together with the audio focus management can make the app volume be controlled more precisely.

clicky6 commented 11 months ago

It's good that I didn't create a feature request, as it would have been a duplicate. However, I found it challenging to comprehend your feature request.Like what was your exact point.

RickyM7 commented 11 months ago

Hahaha, I'm sorry, English isn't my first language, so it's kind of difficult to explain my ideas yet.

clicky6 commented 11 months ago

Oh, OKAY! It was still understandable.

But it's disheartening to see no progress on this feature request that you opened way back in 2020. Most applications use a precise volume format out of 100, as seen in YouTube Vanced, default media player in Samsung devices, Libretube, and even in Windows with the New Windows Media Player and VLC.I don't understand why they haven't implemented this yet in NewPipe.

RickyM7 commented 11 months ago

For sure, I personally expected this feature to have already been added, but NewPipe has several good features "frozen" in pull requests, however, I understand that each feature needs to be well reviewed before being implemented and this takes some time. Anyway, I really appreciate your willingness to add this feature.