TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.56k stars 3.07k forks source link

Loading Bandcamp albums takes too long #5934

Open fynngodau opened 3 years ago

fynngodau commented 3 years ago

Checklist

Steps to reproduce the bug

Open a Bandcamp album containing as many tracks as possible, but not more than 9 tracks.

Actual behaviour

NewPipe queries BandcampPlaylistStreamInfoItemExtractor.getThumbnailUrl() for every single track as soon as the album is opened before any part of the album is displayed.

Expected behavior

Because this method call needs to do an additional web query for each track for Bandcamp, the call should be executed together with the query that downloads the cover art, i.e. it should display the rest of the album with placeholder images while the call is being executed.

More info

Currently, a workaround is implemented to avoid long loading times for large albums: when there are at least 10 tracks in a playlist, each stream in the playlist is displayed as having the same cover art (code).

goyalyashpal commented 3 years ago

hi, can u give a link of a Bandcamp album etc for sample/example?

ghost commented 3 years ago

a link of a Bandcamp album etc for sample/example?

Here is one with 19 songs:

goyalyashpal commented 2 years ago

@Symbian9 i just opened the above shared link and it unnaturally opened almostly instantly on clicking "Show info"

Tried with following other links as well, these took somewhat more time, but still not so much:

Vers: