TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.81k stars 3.09k forks source link

Floating Action Button for search function #6194

Open skyGtm opened 3 years ago

skyGtm commented 3 years ago

Checklist

Describe the feature you want

Floating action button for search functionality at the bottom of the main page and search results page (and other places as required). and (may be) ability to disable it from the settings (for people who don't require it)

Is your feature request related to a problem? Please describe it

As the devices are becoming longer, it is difficult to reach search icon at the top of the screen while using the app with one hand.

Additional context

How will you/everyone benefit from this feature?

People, who own bigger devices, don't have to stretch their finger to reach to search button.

SameenAhnaf commented 3 years ago

What do you think about having ability to open drawer from any activity within the app (except full screen)? Search option as well as other options will be a one handed experience.

Suggested layout ![IMG_20210428_221117](https://user-images.githubusercontent.com/79245641/116436917-b024c200-a86e-11eb-8424-cec632f9683a.jpg) Sorry for the shabby condition.

Top bar on video info needs to have a come back. Here is the reason: https://github.com/TeamNewPipe/NewPipe/issues/3135#issuecomment-731950227

All video interface options could be replaced in the top bar. Only, seek bar is the exception. This will let us get into any chapter or set any playback speed even before playing the video! Primary controls and Search icon: On the top bar Secondary controls: In video info (or three dots menu) Seek bar: As usual Swipe up gesture: Swipe up gesture Exit video: Long press on main player interface

Screenshot ![IMG_20210428_213312](https://user-images.githubusercontent.com/79245641/116436575-58865680-a86e-11eb-8180-d64074d4e730.jpg)

@mhmdanas @skyGtm I think, "Back" icon on top bar (of video info, queue manager, playlist feed, channel feed, search results) is unnecessary. It's quite hard to get into main page and there should be a method. What is your opinion regarding the replacement of the icon.

  1. 👀 Keep it as usual
  2. 👍 Home icon and Use as "Keep activities and back to main page"
  3. ♥️ Cross icon and use as "Clear activities and back to main page"
triallax commented 3 years ago

@SameenAhnaf that's an interesting idea, but it's way too general for this issue. Your idea would be best discussed in a separate issue.

infinitewaveparticle commented 3 years ago

@SameenAhnaf did you open a new issue for this? I was just going to request the hamburger menu be available on the search results page, but having it persist throughout the app would be even better!

infinitewaveparticle commented 3 years ago

This particular issue, though (floating search) would close my #5902 as well

infinitewaveparticle commented 3 years ago

I'll let the devs decide on which path to take, re: #5902 vs #6194

Sent from ProtonMail mobile

-------- Original Message -------- On Aug 1, 2021, 8:43 AM, SameenAhnaf wrote:

@.***(https://github.com/infinitewaveparticle) I didn't open this issue. Maybe, I should have marked this as a duplicate though.

Anyway, you may copy my suggestion or close #5902.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

litetex commented 3 years ago

As the devices are becoming longer, it is difficult to reach search icon at the top of the screen while using the app with one hand.

Some manufacturers provide special options for that, e.g. https://consumer.huawei.com/en/support/content/en-us00785200/

SameenAhnaf commented 3 years ago

@litetex Almost all recent phones have it. But too small fonts actually don't solve the problem.

It'd be nice to see Samsung's one UI layout. Scroll up continuously and access top bar easily. But I'm not sure how to implement it in the middle of playlists or channel feed. As expected, many users may have scrolled quite down and still may want to access the top bar easily. Does anyone have any idea?

One UI layout ![IMG_20210913_090642](https://user-images.githubusercontent.com/79245641/133018027-e9680bea-f2c1-46fb-8511-e33db83f2010.jpg)
sosasees commented 3 months ago

the title bar could be 2 rows tall in portrait mode:

this is the same idea as the One UI layout but more suited for really long pages with quite a few options in the title bar, like playlists in NewPipe