search

TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.3k stars 3.04k forks source link

Unrecoverable Player Error on changing playback speed #6392

Closed iamkroot closed 3 years ago

iamkroot commented 3 years ago

Checklist

Steps to reproduce the bug

  1. Open any video from Youtube
  2. Press on playback speed to open popup menu
  3. Try to increase the Tempo over 1x:
    • it works fine when decreasing speed from 1x to 0.75x, or even increasing from 0.75x to 1x.
    • Just doesn't seem to handle anything above 1x.
    • Changing pitch doesn't cause error.
    • Changing the step doesn't help
    • And the crash happens before pressing "ok" on the popup menu, as soon as I press the increase button and it goes over 1x.

Actual behaviour

Expected behavior

Logs

Did not get any Error Report page.

Device info

homocomputeris commented 3 years ago

I have the same issue with 0.21.8

homocomputeris commented 3 years ago

Worked around by switching to webm.

iamkroot commented 3 years ago

For me, it got fixed when I moved to a different custom ROM (SparkOS). So probably some codec error?

homocomputeris commented 3 years ago

Maybe. I thought the codecs are supposed to be shipped with NewPipe

litetex commented 3 years ago

Is this fixed now?

homocomputeris commented 3 years ago

In my case, I still encounter the error with any codec.

litetex commented 3 years ago

@iamkroot Stated earlier:

For me, it got fixed when I moved to a different custom ROM (SparkOS). So probably some codec error?

Looks like a OS problem. I don't think we can do much on app side here...

litetex commented 3 years ago

I thought the codecs are supposed to be shipped with NewPipe

No. These are shipped with the device / OS: https://developer.android.com/guide/topics/media/media-formats

Also take a look at the exoplayer requirements:

If those are conditions are not met then we can't guarantee anything from the app side.

homocomputeris commented 3 years ago

Well, some LineageOS bug, probably.

How can I get any logs for "Unrecoverable Player Error occurred", so that I can report codecs issues to LOS?

litetex commented 3 years ago

People are asking so much for that I now create a Gist for it 😆

Use logcat which is shipped with ADB

There are a bunch of manual online available, e.g:

https://gist.github.com/litetex/ab061f158aeba824713e9a558e8e98ff

homocomputeris commented 3 years ago

Thanks. I'm more or less familiar with logcat, the problem is it generates like 100 events per second. Any hint what I should look for in logcat? Searching for newpipe in logcat just doesn't return any results.

litetex commented 3 years ago

Hmm I usually - when a problem occurs - I checkout the NewPipe repo (in Android studio) and debug the app via the integrated emulator/on my real device (via USB) as it's much easier to debug 😄 So I don't know the pure commandline tool relatively good.

Maybe the documentation helps: https://developer.android.com/studio/command-line/logcat#filteringOutput

Note also that release builds are usually minimized. I think stuff like debug logging is disabled there.

opusforlife2 commented 3 years ago

Note also that release builds are usually minimized. I think stuff like debug logging is disabled there.

Indeed. @homocomputeris Please check the logs of the RC in the pinned issue and see if you get any useful information.

tsiflimagas commented 3 years ago

@homocomputeris try filtering logs by pid. Do like logcat --pid=$(pgrep -f org.schabi.newpipe)

github-actions[bot] commented 3 years ago

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.