Can't interact with app/screen below popup player on Android 12

Joristdh commented 3 years ago

Checklist

[x] I am using the latest version - 0.21.7
[x] I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
[x] I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
[x] This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

This is a bug on Android 12 beta 3
Open a video in the popup player (it doesn't matter which video or how you open it)
Make sure the popup uses the full width of the screen (when in portrait)
Open another app below the popup player, go to the home screen or open recent apps
Try to interact with the screen below the popup

Actual behavior

All touches to the app/screen below the popup are ignored, because of the following behavior change in Android 12: https://developer.android.com/about/versions/12/behavior-changes-all#untrusted-touch-events

Expected behavior

The app below the popup responds to the touches.

Workaround

For now this issues can be solved per device by running the following ADB command: adb shell settings put global block_untrusted_touches 0

Device info

Android version/Custom ROM version: Android 12 beta 3
Device model: Pixel 3

werjany commented 2 years ago

@moneytoo @vnckppl Sorry to ping you, but could you also test this APK and see if the issue is gone too?

It seems when setting a lower opacity to the close button (up to 0.8), we can also use the popup player on Android 12 and higher.

Could you test the following changes to see if they work (the source code is available here)? Thank you!

app-debug.zip

That works for me too! Thanks!

book000 commented 2 years ago

The build posted by @TiA4f8R confirms that the popups work as expected! (Pixel 3a / Android 12) Thank you.

alexsohn1126 commented 2 years ago

@moneytoo @vnckppl Sorry to ping you, but could you also test this APK and see if the issue is gone too?

It seems when setting a lower opacity to the close button (up to 0.8), we can also use the popup player on Android 12 and higher.

Could you test the following changes to see if they work (the source code is available here)? Thank you!

app-debug.zip

Amazing. Worked for me. Using Galaxy S10+ with Android 12.

vnckppl commented 2 years ago

@moneytoo @vnckppl Sorry to ping you, but could you also test this APK and see if the issue is gone too?

It seems when setting a lower opacity to the close button (up to 0.8), we can also use the popup player on Android 12 and higher.

Could you test the following changes to see if they work (the source code is available here)? Thank you!

app-debug.zip

Works great! I can navigate normally in underlying apps and dragging the popup window to the closing button works too.

AudricV commented 2 years ago

This bug should have been fixed by #8279, included in the upcoming release, 0.23.0. Closing as resolved.

TeamNewPipe / NewPipe