search

TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.83k stars 3.08k forks source link

Consider to release v0.10.0 #682

Closed theScrabi closed 7 years ago

theScrabi commented 7 years ago

Can we now consider to release version v0.10.0? Now where more or less all feature work stable enough to be usable.

ghost commented 7 years ago

@theScrabi: Can we at least update NewPipeExtractor first now that it supports decrypting URLs correctly again?

And how about multiple services? Or will we do that with the release after v0.10.0?

theScrabi commented 7 years ago

I'm not a huge fan, of putting to much changes into one version. Because the more U change the more unstable it gets. Also I made the experience that user will find bugs you aren't aware of.

I'd like to release now, and than stick to a constant release cycle again. (Before the huge refactoring of the extractor we had an almost every week cycle).

We can consider multi service support in a few versions later, but not now.

ghost commented 7 years ago

@theScrabi: I'm OK with releasing now, but only if we update NewPipeExtractor first.

I'm not a fan of too much changes in one release either.

We already have it in NewPipeExtractor, btw I'm working on adding it to NewPipe, but I've been really busy the last few days.

theScrabi commented 7 years ago

@mauriciocolli updated the extractor here

mauriciocolli commented 7 years ago

I already updated the extractor https://github.com/TeamNewPipe/NewPipe/commit/23f70d6b8b04bb7ba6483b54d042f6f094f71775.

But one thing to always keep in mind when updating is the database. If we update carelessly we could end up clearing the database, which is not very cool.

PS: It still have some annoying bugs in the extractor, so I wouldn't recommend release right now (YouTube has been changing in the past days).

ghost commented 7 years ago

Oh, I didn't notice. But if there are some nasty bugs, I'd wait indeed.

theScrabi commented 7 years ago

This is why we should consider to have a beta app. Because there will always be bugs. Some people can get along with a few bugs some can't. If we have beta people could decide them selfs.

ghost commented 7 years ago

@theScrabi: I agree, but what'll we do with version numbering?

theScrabi commented 7 years ago

I'd do it the way we do it now, just put a beta in front of the version. like v0.10.0 v-beta-0.10.1 or beta-v0.10.1

(We'd have to put it in front because only this way fdroid can distinguish between beta and nonbeta)

theScrabi commented 7 years ago

YouTube has been changing in the past days

I saw that. Due to that new UI some of the things that still work are rather unclear if they will work in the future. Example: In the channels view on youtube there was a "load next" button. We used that button to get the url for the ajax request for the next video items. This button does not exist in the new UI anymore. It seems NP is till capable to load the old website where this button still exists. But for how long?

But atm I'm more concerned of the database, because it would not be such a huge problem if the crawler stopped working while a new version is released. We then just hat to asap release a version that fixes that problem (happens to the past will happen to the future as well).

@mauriciocolli: What in particular does not yet work? I couldn't find anything that drove me that crazy that I would not release yet.

mauriciocolli commented 7 years ago

I fixed some error that caused these annoyances (at least the ones that I noticed), but just a brief summary:

They are very annoying because every time they ask the user to report (in almost every search, in every "next videos"...).

theScrabi commented 7 years ago

Yea. I see.

theScrabi commented 7 years ago

Although these are extractor related bugs right? I have to admid that It's not that bad. Over all NewPipe is pretty usable. So form my perception of user experience of usage I'd vote for release.

Anyway is the database still an issue tho?

mauriciocolli commented 7 years ago

Well, it was bad before I fixed them (asking the user to report to do the most trivial of things like search).

The database was more of a warning about the fact that we'd have to create multiple tiny migrations, which is not ideal. But that will not be a problem anymore as we'll have a different build so we can see when it's the best moment to release.

theScrabi commented 7 years ago

Well if its not the code, then there is nothing that can prevent us from release.

theScrabi commented 7 years ago

So I've released: https://github.com/TeamNewPipe/NewPipe/releases/tag/v0.10.0

Shame on me if something went wrong.

TobiGr commented 7 years ago

Open youtube links directly from search (fixes #35) #692 Support dark theme in file picker #699 (fixes #646)

Correct me if I am wrong but I think these two were only merged to dev branch and are not included in the 0.10.0 release.

theScrabi commented 7 years ago

you are right :) removed it

rbozan commented 7 years ago

The version of NewPipe on fdroid hasn't updated I think

theScrabi commented 7 years ago

Several apps on fdroid haven't updated yet. I don't know what takes them so long again.