[x] This issue contains only one refactor request. I will open one issue for every refactor I want to request.
Describe the feature you want
In my opinion one should merge the Dialogs from FeedFragment, StatisticsPlaylistFragment, LocalPlaylistFragment, PlaylistFragment;
mostly called showStreamItemDialog (showStreamItemDialog) and showStreamDialog (every other)
Also assimilate or even merge the single and long press actions for play / play all / enqueue / popup / background play in
LocalPlaylistFragment, PlaylistFragment, VideoDetailFragment in the methods
called handleResult (LocalPlaylistFragment, PlaylistFragment), onLongClick/onClick (VideoDetailFragment)
Is your feature request related to a problem? Please describe it
Adding a new action or improving a existing one requires finding every possible place where they are called.
Additional context
Mostly a result of my work on #6872.
How will you/everyone benefit from this feature?
Instead of having to make sure that new actions / changes are applied in every fragment only one obvious file would have to be changed. Searching for where the actions are used would be simplified.
I dont think this actually is a feature request, but is even less of a bug so...
Also the button and dialog refactor maybe should be separate issues?
Checklist
Describe the feature you want
In my opinion one should merge the Dialogs from
FeedFragment
,StatisticsPlaylistFragment
,LocalPlaylistFragment
,PlaylistFragment
; mostly calledshowStreamItemDialog
(showStreamItemDialog) andshowStreamDialog
(every other)Also assimilate or even merge the single and long press actions for play / play all / enqueue / popup / background play in
LocalPlaylistFragment
,PlaylistFragment
,VideoDetailFragment
in the methods calledhandleResult
(LocalPlaylistFragment, PlaylistFragment),onLongClick
/onClick
(VideoDetailFragment)Is your feature request related to a problem? Please describe it
Adding a new action or improving a existing one requires finding every possible place where they are called.
Additional context
Mostly a result of my work on #6872.
How will you/everyone benefit from this feature?
Instead of having to make sure that new actions / changes are applied in every fragment only one obvious file would have to be changed. Searching for where the actions are used would be simplified.
I dont think this actually is a feature request, but is even less of a bug so... Also the button and dialog refactor maybe should be separate issues?