Use custom tags while playing

solopa commented 2 years ago

Checklist

[x] I checked, but didn't find any exact duplicates (open OR closed) of this issue in the repo (I link below the similar ones).
[x] I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
[x] This issue contains only one feature request. I will open one issue for every feature I want to request.

What feature do you want?

First off, thank you for this awesome app. The feature I'd like to propose is manually tagging a particular video. Specifically, change the title and/or the author of it. There has been some discussion before about tagging a video for downloading purposes (https://github.com/TeamNewPipe/NewPipe/issues/183 https://github.com/TeamNewPipe/NewPipe/issues/4341) but this would serve too while playing the song.

Why do you want this feature?

I use NewPipe while driving and playing YouTube videos (songs in my case) via bluetooth. In my player it shows the title of the video as the title, the user that uploaded the video as the author and "Unknown album" as the album. However, it only shows the first 20-25 characters (without scrolling the rest) so, if the video description is too cumbersome, I won't know the song that is playing (for example, many times the title starts with the name of the band and then the title of the song, so I only see the first part).

How could this be implemented?

If the stream that is playing (the one from YouTube), has this information already embedded maybe this feature is not feasible. If not, I propose this changes to the UI (all of them in the screen that shows while you are playing a video in NewPipe): To edit a tag: Long pressing the title (right now it copies it to the clipboard) or the uploader changes the control to a edit text where you can modify it to whatever you want. To know which were the original values: Showing them after the description of the video and before its tags in the information tab. To reset the tags to the original values: Adding a new button next to the others (background, share, open in browser, ...) called "Reset tags" that reverts everything to the original values (deletes all the custom tags). Then, when streaming/playing the song, NewPipe would use the custom tags if they exist or the original ones if they don't.

I don't know if this custom tags could be used too to the download values, but maybe it would solve those other issues too.

Yamaha1692 commented 2 years ago

Would also like to see sound file tagging... (Even if its manual at each download) Would allow the native music players to sort the music correctly.

Vs using mp3 tagger to redo them all :-)

opusforlife2 commented 2 years ago

I use NewPipe while driving and playing YouTube videos (songs in my case) via bluetooth. In my player it shows the title of the video as the title, the user that uploaded the video as the author and "Unknown album" as the album.

@solopa One solution to this is to use YT Music. The songs are almost invariably named correctly.

Would allow the native music players to sort the music correctly.

@Yamaha1692 I would suggest you rather go with yt-dlp for this (through Seal if on Android). It can embed the entire metadata into the song file, giving a bunch of info to your music player app to do its thing.

TeamNewPipe / NewPipe