Incorrect behavior when removing a playing video from the background queue when loop state is changed after selection

lambdadog commented 2 years ago

Checklist

[X] I am able to reproduce the bug with the latest version.
[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug.
[X] I have read and understood the contribution guidelines.

Affected version

0.23.0

Steps to reproduce the bug

Add multiple videos to background play queue
Disable looping
Tap last video in play queue to begin it playing
Set play queue to loop all
Remove last video (currently playing) from play queue

Expected behavior

The play queue will loop, returning to playing the first video.

Actual behavior

A new video will be queued from autoplay and it will begin playing.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 10, AOSP

Affected device model

Pixel 4 XL

Additional information

The behavior of removing a playing video from the background play queue seems to depend on the loop setting when you select it (start it playing), rather than the play queue's current loop setting.

opusforlife2 commented 2 years ago

Does it work correctly if you avoid step 2?

SameenAhnaf commented 2 years ago

I tried reproducing the bug myself. Well, you need to change loop state to "Repeat all", then to disable and change again to "Repeat all".

lambdadog commented 2 years ago

@opusforlife2 It doesn't, presuming your queue has looping disabled already (the default behavior I believe on a fresh launch). I only added that step because your background queue could conceivably already be set to a different loop setting, as its value is stored even when starting a new queue.

lambdadog commented 2 years ago

@SameenAhnaf I'm not sure if I entirely understand this reply, sorry. I did update the issue to use the wording "loop all" as opposed to just loop, as this made me realize my wording was ambiguous.

opusforlife2 commented 2 years ago

@lambdadog Default setting aside, does removing the queue work correctly when you're using "loop all" throughout?

lambdadog commented 2 years ago

@opusforlife2 Behavior is correct when "loop all" is set prior to selecting the video, so yes.

TeamNewPipe / NewPipe