Update Invidious and Piped instances

opusforlife2 commented 2 years ago

Checklist

[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
[X] I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
[X] This issue contains only one feature request.
[X] I have read and understood the contribution guidelines.

Feature description

It's been a long time since the list of instances in the manifest was updated. The list has changed a lot since then.

Why do you want this feature?

New instances can be used with Newpipe.

Additional information

Should old instances be deleted from the list? I was wondering about this. Users might come across links to now-defunct instances. I see no issue with these links opening in Newpipe, since the domain is discarded, anyway.

So maybe the list should contain all previous and current instances for maximum link compatibility.

markusgerber76 commented 2 years ago

Where is the UI for piped? How does one add a piped instance?

triallax commented 2 years ago

@markusgerber76 are you interested in fixing this issue? If so, I'll assign you to it.

To answer your question, here's the Piped repo, and here's the instances list. Piped instances are added to app/src/main/AndroidManifest.xml and also in the extractor. See https://github.com/TeamNewPipe/NewPipe/pull/6557 and https://github.com/TeamNewPipe/NewPipeExtractor/pull/668 for an example of how this is done.

Should old instances be deleted from the list? I was wondering about this. Users might come across links to now-defunct instances. I see no issue with these links opening in Newpipe, since the domain is discarded, anyway.

So maybe the list should contain all previous and current instances for maximum link compatibility.

I agree with everything you say.

litetex commented 2 years ago

I wouldn't recommend updating the list:

There is currently work done on https://github.com/TeamNewPipe/NewPipe/pull/8220
We shouldn't use a hardcoded list of instances, because it's impossible to keep up with updating ;)

triallax commented 2 years ago

here is currently work done on https://github.com/TeamNewPipe/NewPipe/pull/8220

We don't know when that might be merged. Also, it doesn't apply to Piped instances.

We shouldn't use a hardcoded list of instances, because it's impossible to keep up with updating ;)

What do you propose then?

litetex commented 2 years ago

I think we should fix this in the long run by doing 2 things:

https://github.com/TeamNewPipe/NewPipe/issues/7456 - This fixes the hardcoded entries inside the Android manifest file
Keep a user-editable list of known instances (Noted that already inside #8220 - but we may also open a new issue) - This fixes the hardcoded entries inside the NewPipe extractor

Maybe in the short term we can update them but that's definitely not a future proof solution.

opusforlife2 commented 2 years ago

Isn't intent handling extremely limited Android 12 onwards?

opusforlife2 commented 1 year ago

We can probably copy a list of the latest working instances off of Libredirect.

TeamNewPipe / NewPipe