TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.51k stars 3.06k forks source link

Not work with a poor Internet connection #8614

Open asingl opened 2 years ago

asingl commented 2 years ago

Checklist

Affected version

0.23.1

Steps to reproduce the bug

Stopping when the Internet connection is bad.

Expected behavior

Timeout as in version 0.23.0 or the possibility of setting it.

Actual behavior

I have places with poor internet connection (subways and places away from the city). In this case, the playback stops and you have to start the video from the beginning. And you can't change the connection timeout in the settings of the application.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 9

Affected device model

No response

Additional information

I use a 4G internet connection.

litetex commented 2 years ago

Can't reproduce: Switched between WiFi and mobile internet → no problems. Turned of mobile internet and WiFi and turned them on again, no problems either. Has to be a provider specific problem.

Also the issue is invalid:

Timeout as in version 0.23.0 or the possibility of setting it.

There was no such thing in the last few version.

More information is required.

asingl commented 2 years ago

I don't use Wi-Fi, I only use 4G mobile internet. I have internet interruptions of up to 15-20 minutes. I listen to audio, but I don't watch video. Version 0.23.0 waits for the internet to turn on and continues to play audio. Version 0.23.1 stops playback with an error on the cell phone lock screen. I have to go back into the application and start playback again.

AudricV commented 2 years ago

Version 0.23.0 waits for the internet to turn on and continues to play audio

Older versions "wait" by retrying 231-1 times (Java's Integer.MAX_VALUE) before throwing an exception. That's not the case anymore, we use now the default retry count of ExoPlayer.

As you can think, this was a bad idea in terms of energy consumption but was statisfying your case.

I'm not sure unfortunately if we will be able to do something for cases like yours.

asingl commented 2 years ago

Please add to the settings the ability to set the number of retries to connect. Those people who need it will change this parameter.

ChiefMikeK commented 2 years ago

fwiw you can download the audio or video file before hand then delete it afterwards.

asingl commented 2 years ago

It's very very inconvenient. I listen to a lot of videos in a place with bad internet for a long time.

opusforlife2 commented 2 years ago

we use now the default retry count of ExoPlayer

Considering that the YT app also uses ExoPlayer, they must have a way to deal with this, because spotty Internet connection is a staple in developing countries, and yet I've never seen the YT app encounter timeouts or anything similar.