TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.51k stars 3.06k forks source link

Player-related code that should be improved #8616

Open litetex opened 2 years ago

litetex commented 2 years ago

I and Stypox noticed some strange things while reviewing/refactoring the player https://github.com/TeamNewPipe/NewPipe/pull/8170 (which were also there before the refactoring):

Other things to do:

J-Stutzmann commented 1 year ago

I think I have a decent explanation for what item 2 is/does:

What this does, for a well chosen TOSS_FLING_VELOCITY that:

is to snap a flung popup to the edge of what popupLayoutParams says is the available space in the (approximate) direction it was sent.