TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.56k stars 3.07k forks source link

video always starts in full screen on unihertz titan pocket #8636

Closed cheesehead544 closed 2 years ago

cheesehead544 commented 2 years ago

Checklist

Affected version

0.23.1

Steps to reproduce the bug

play a video with screen rotation locked in portrait. the video starts in portrait mode full screen even though the option is off. the exit full screen button does nothing. 2 I believe this may have something to do with the fact that the titan pocket has a 716*720(so almost 1:1) screen. some apps misinterpret what is landscape / portrait mode. I tested from the latest version down to 22.2.

Expected behavior

when playing a video with the "start in full screen option" disabled I would expect the video to stay at the size it is before you click play

Actual behavior

the video switches to full screen automatically and I am unable to leave it without pressing the back button / stopping video playback

Screenshots/Screen recordings

https://user-images.githubusercontent.com/32103720/179356958-74219e1d-f8fc-4180-a358-a6d979832c38.mp4

Logs

No response

Affected Android/Custom ROM version

android 11

Affected device model

unihertz titan pocket

Additional information

No response

edit: added video

cheesehead544 commented 2 years ago

actually it might not be rotation-related as the interface is not rotated after entering full screen compared to before.

SameenAhnaf commented 2 years ago

I think, https://github.com/TeamNewPipe/NewPipe/pull/6059 is the reason. It forces video to be played on full screen while using split screen.

cheesehead544 commented 2 years ago

I can confirm forcing tablet mode on fixes the problem. I wonder is this just a quirk with how newpipe detects splitscreen? because I don't use that feature at all but leaving tablet mode on auto seems to result in it being turned off

opusforlife2 commented 2 years ago

It's probably the quirky resolution, with width smaller than height, which causes this.